GitLab

See https://github.com/jbenet/go-ipfs/issues/153#issuecomment-63350535

for higher SnR at IPFS_LOGGING=info

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

@jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

This commit makes GetProviders (sync) respect the request context. It
also amends all of GetProviders' callsites to pass a context in. This
meant changing the signature of the dht's handlerfunc.

I think I'll start referring to the request context as Vito Corleone.

cc @whyrusleeping @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

the important change here is that within FindProvidersAsync, the channel
is closed using a `defer`. This ensures the channel is always closed,
regardless of the path taken to exit.

+ misc cleanup

cc @whyrusleeping @jbenet

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

- distinguish log.Error and log.Errorf functions
- Initialize structs with field names
- A bit of unreachable code (defers)

dht doesn't need the whole network interface, only needs a Dialer.
(much reduced surface of possible errors)

The query-- once it's actually attempting to connect to a peer--
should be the one connecting.

![](http://m.memegen.com/77n7dk.jpg)

and other logging switches. I kept the u.PErr and u.POut in cli
commands, as those do need to write raw output directly.

- use log.* instead of u.*
- use automatic type conversions to .String()
  (Peer.String() prints nicely, and avoids calling b58 encoding
  until needed)