Commit a4329c39 authored by Aarsh Shah's avatar Aarsh Shah

better naming

parent ac6d9f25
......@@ -49,14 +49,14 @@ type RoutingTable struct {
PeerRemoved func(peer.ID)
PeerAdded func(peer.ID)
// maxLastUsefulAt is the max threshold/upper limit for the value of "LastUsefulAt"
// of the peer in the bucket above which we will evict it to make place for a new peer if the bucket
// usefulnessGracePeriod is the maximum grace period we will give to a
// peer in the bucket to be useful to us, failing which, we will evict it to make place for a new peer if the bucket
// is full
maxLastUsefulAt float64
usefulnessGracePeriod float64
}
// NewRoutingTable creates a new routing table with a given bucketsize, local ID, and latency tolerance.
func NewRoutingTable(bucketsize int, localID ID, latency time.Duration, m peerstore.Metrics, maxLastUsefulAt float64) (*RoutingTable, error) {
func NewRoutingTable(bucketsize int, localID ID, latency time.Duration, m peerstore.Metrics, usefulnessGracePeriod float64) (*RoutingTable, error) {
rt := &RoutingTable{
buckets: []*bucket{newBucket()},
bucketsize: bucketsize,
......@@ -70,7 +70,7 @@ func NewRoutingTable(bucketsize int, localID ID, latency time.Duration, m peerst
PeerRemoved: func(peer.ID) {},
PeerAdded: func(peer.ID) {},
maxLastUsefulAt: maxLastUsefulAt,
usefulnessGracePeriod: usefulnessGracePeriod,
}
rt.ctx, rt.ctxCancel = context.WithCancel(context.Background())
......@@ -154,7 +154,7 @@ func (rt *RoutingTable) addPeer(p peer.ID, queryPeer bool) (bool, error) {
// in that bucket with a LastSuccessfulOutboundQuery value above the maximum threshold and replace it.
allPeers := bucket.peers()
for _, pc := range allPeers {
if float64(time.Since(pc.LastUsefulAt)) > rt.maxLastUsefulAt {
if float64(time.Since(pc.LastUsefulAt)) > rt.usefulnessGracePeriod {
// let's evict it and add the new peer
if bucket.remove(pc.Id) {
bucket.pushFront(&PeerInfo{Id: p, LastUsefulAt: lastUsefulAt, LastSuccessfulOutboundQueryAt: time.Now(),
......
Markdown is supported
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment