swarm_dial.go 12 KB
Newer Older
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1 2 3
package swarm

import (
4
	"context"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
5 6 7 8 9
	"errors"
	"fmt"
	"sync"
	"time"

Jeromy's avatar
Jeromy committed
10 11 12 13 14
	addrutil "github.com/libp2p/go-addr-util"
	iconn "github.com/libp2p/go-libp2p-interface-conn"
	lgbl "github.com/libp2p/go-libp2p-loggables"
	peer "github.com/libp2p/go-libp2p-peer"
	ma "github.com/multiformats/go-multiaddr"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
15 16 17 18 19 20 21 22 23 24 25 26 27 28
)

// Diagram of dial sync:
//
//   many callers of Dial()   synched w.  dials many addrs       results to callers
//  ----------------------\    dialsync    use earliest            /--------------
//  -----------------------\              |----------\           /----------------
//  ------------------------>------------<-------     >---------<-----------------
//  -----------------------|              \----x                 \----------------
//  ----------------------|                \-----x                \---------------
//                                         any may fail          if no addr at end
//                                                             retry dialAttempt x

var (
29 30
	// ErrDialBackoff is returned by the backoff code when a given peer has
	// been dialed too frequently
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
31
	ErrDialBackoff = errors.New("dial backoff")
32 33 34 35 36 37

	// ErrDialFailed is returned when connecting to a peer has ultimately failed
	ErrDialFailed = errors.New("dial attempt failed")

	// ErrDialToSelf is returned if we attempt to dial our own peer
	ErrDialToSelf = errors.New("dial to self attempted")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
38 39 40 41 42 43 44
)

// dialAttempts governs how many times a goroutine will try to dial a given peer.
// Note: this is down to one, as we have _too many dials_ atm. To add back in,
// add loop back in Dial(.)
const dialAttempts = 1

Jeromy's avatar
Jeromy committed
45 46 47
// number of concurrent outbound dials over transports that consume file descriptors
const concurrentFdDials = 160

Jeromy's avatar
Jeromy committed
48 49 50
// number of concurrent outbound dials to make per peer
const defaultPerPeerRateLimit = 8

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
51 52 53
// DialTimeout is the amount of time each dial attempt has. We can think about making
// this larger down the road, or putting more granular timeouts (i.e. within each
// subcomponent of Dial)
54
var DialTimeout = time.Second * 10
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80

// dialbackoff is a struct used to avoid over-dialing the same, dead peers.
// Whenever we totally time out on a peer (all three attempts), we add them
// to dialbackoff. Then, whenevers goroutines would _wait_ (dialsync), they
// check dialbackoff. If it's there, they don't wait and exit promptly with
// an error. (the single goroutine that is actually dialing continues to
// dial). If a dial is successful, the peer is removed from backoff.
// Example:
//
//  for {
//  	if ok, wait := dialsync.Lock(p); !ok {
//  		if backoff.Backoff(p) {
//  			return errDialFailed
//  		}
//  		<-wait
//  		continue
//  	}
//  	defer dialsync.Unlock(p)
//  	c, err := actuallyDial(p)
//  	if err != nil {
//  		dialbackoff.AddBackoff(p)
//  		continue
//  	}
//  	dialbackoff.Clear(p)
//  }
//
Jeromy's avatar
Jeromy committed
81

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
82
type dialbackoff struct {
Jeromy's avatar
Jeromy committed
83
	entries map[peer.ID]*backoffPeer
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
84 85 86
	lock    sync.RWMutex
}

Jeromy's avatar
Jeromy committed
87 88 89 90 91
type backoffPeer struct {
	tries int
	until time.Time
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
92 93
func (db *dialbackoff) init() {
	if db.entries == nil {
Jeromy's avatar
Jeromy committed
94
		db.entries = make(map[peer.ID]*backoffPeer)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
95 96 97 98
	}
}

// Backoff returns whether the client should backoff from dialing
Jeromy's avatar
Jeromy committed
99 100
// peer p
func (db *dialbackoff) Backoff(p peer.ID) (backoff bool) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
101
	db.lock.Lock()
Jeromy's avatar
Jeromy committed
102
	defer db.lock.Unlock()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
103
	db.init()
Jeromy's avatar
Jeromy committed
104 105 106 107 108 109
	bp, found := db.entries[p]
	if found && time.Now().Before(bp.until) {
		return true
	}

	return false
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
110 111
}

Jeromy's avatar
Jeromy committed
112 113 114
const baseBackoffTime = time.Second * 5
const maxBackoffTime = time.Minute * 5

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
115 116 117 118 119
// AddBackoff lets other nodes know that we've entered backoff with
// peer p, so dialers should not wait unnecessarily. We still will
// attempt to dial with one goroutine, in case we get through.
func (db *dialbackoff) AddBackoff(p peer.ID) {
	db.lock.Lock()
Jeromy's avatar
Jeromy committed
120
	defer db.lock.Unlock()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
121
	db.init()
Jeromy's avatar
Jeromy committed
122 123 124 125 126 127 128 129 130 131 132 133 134 135 136
	bp, ok := db.entries[p]
	if !ok {
		db.entries[p] = &backoffPeer{
			tries: 1,
			until: time.Now().Add(baseBackoffTime),
		}
		return
	}

	expTimeAdd := time.Second * time.Duration(bp.tries*bp.tries)
	if expTimeAdd > maxBackoffTime {
		expTimeAdd = maxBackoffTime
	}
	bp.until = time.Now().Add(baseBackoffTime + expTimeAdd)
	bp.tries++
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
137 138 139 140 141 142
}

// Clear removes a backoff record. Clients should call this after a
// successful Dial.
func (db *dialbackoff) Clear(p peer.ID) {
	db.lock.Lock()
Jeromy's avatar
Jeromy committed
143
	defer db.lock.Unlock()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176
	db.init()
	delete(db.entries, p)
}

// Dial connects to a peer.
//
// The idea is that the client of Swarm does not need to know what network
// the connection will happen over. Swarm can use whichever it choses.
// This allows us to use various transport protocols, do NAT traversal/relay,
// etc. to achive connection.
func (s *Swarm) Dial(ctx context.Context, p peer.ID) (*Conn, error) {
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
	if p == s.local {
		log.Event(ctx, "swarmDialSelf", logdial)
		return nil, ErrDialToSelf
	}

	return s.gatedDialAttempt(ctx, p)
}

func (s *Swarm) bestConnectionToPeer(p peer.ID) *Conn {
	cs := s.ConnectionsToPeer(p)
	for _, conn := range cs {
		if conn != nil { // dump out the first one we find. (TODO pick better)
			return conn
		}
	}
	return nil
}

// gatedDialAttempt is an attempt to dial a node. It is gated by the swarm's
// dial synchronization systems: dialsync and dialbackoff.
func (s *Swarm) gatedDialAttempt(ctx context.Context, p peer.ID) (*Conn, error) {
177
	defer log.EventBegin(ctx, "swarmDialAttemptSync", p).Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
178 179 180 181 182 183 184

	// check if we already have an open connection first
	conn := s.bestConnectionToPeer(p)
	if conn != nil {
		return conn, nil
	}

185 186
	// if this peer has been backed off, lets get out of here
	if s.backf.Backoff(p) {
187
		log.Event(ctx, "swarmDialBackoff", p)
188 189 190
		return nil, ErrDialBackoff
	}

191 192
	return s.dsync.DialLock(ctx, p)
}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
193

194 195 196 197 198 199 200 201 202 203 204 205
// doDial is an ugly shim method to retain all the logging and backoff logic
// of the old dialsync code
func (s *Swarm) doDial(ctx context.Context, p peer.ID) (*Conn, error) {
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
	// ok, we have been charged to dial! let's do it.
	// if it succeeds, dial will add the conn to the swarm itself.
	defer log.EventBegin(ctx, "swarmDialAttemptStart", logdial).Done()
	ctxT, cancel := context.WithTimeout(ctx, s.dialT)
	conn, err := s.dial(ctxT, p)
	cancel()
	log.Debugf("dial end %s", conn)
	if err != nil {
206 207 208 209
		if err != context.Canceled {
			log.Event(ctx, "swarmDialBackoffAdd", logdial)
			s.backf.AddBackoff(p) // let others know to backoff
		}
210 211 212

		// ok, we failed. try again. (if loop is done, our error is output)
		return nil, fmt.Errorf("dial attempt failed: %s", err)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
213
	}
214 215 216
	log.Event(ctx, "swarmDialBackoffClear", logdial)
	s.backf.Clear(p) // okay, no longer need to backoff
	return conn, nil
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236
}

// dial is the actual swarm's dial logic, gated by Dial.
func (s *Swarm) dial(ctx context.Context, p peer.ID) (*Conn, error) {
	var logdial = lgbl.Dial("swarm", s.LocalPeer(), p, nil, nil)
	if p == s.local {
		log.Event(ctx, "swarmDialDoDialSelf", logdial)
		return nil, ErrDialToSelf
	}
	defer log.EventBegin(ctx, "swarmDialDo", logdial).Done()
	logdial["dial"] = "failure" // start off with failure. set to "success" at the end.

	sk := s.peers.PrivKey(s.local)
	logdial["encrypted"] = (sk != nil) // log wether this will be an encrypted dial or not.
	if sk == nil {
		// fine for sk to be nil, just log.
		log.Debug("Dial not given PrivateKey, so WILL NOT SECURE conn.")
	}

	ila, _ := s.InterfaceListenAddresses()
237
	subtractFilter := addrutil.SubtractFilter(append(ila, s.peers.Addrs(s.local)...)...)
Jeromy's avatar
Jeromy committed
238 239 240 241 242

	// get live channel of addresses for peer, filtered by the given filters
	/*
		remoteAddrChan := s.peers.AddrsChan(ctx, p,
			addrutil.AddrUsableFilter,
243
			subtractFilter,
Jeromy's avatar
Jeromy committed
244 245 246
			s.Filters.AddrBlocked)
	*/

Jeromy's avatar
Jeromy committed
247 248 249 250 251 252 253 254
	//////
	/*
		This code is temporary, the peerstore can currently provide
		a channel as an interface for receiving addresses, but more thought
		needs to be put into the execution. For now, this allows us to use
		the improved rate limiter, while maintaining the outward behaviour
		that we previously had (halting a dial when we run out of addrs)
	*/
Jeromy's avatar
Jeromy committed
255
	paddrs := s.peers.Addrs(p)
256
	goodAddrs := addrutil.FilterAddrs(paddrs,
Jeromy's avatar
Jeromy committed
257
		addrutil.AddrUsableFunc,
258
		subtractFilter,
Jeromy's avatar
Jeromy committed
259 260
		addrutil.FilterNeg(s.Filters.AddrBlocked),
	)
261 262
	remoteAddrChan := make(chan ma.Multiaddr, len(goodAddrs))
	for _, a := range goodAddrs {
Jeromy's avatar
Jeromy committed
263
		remoteAddrChan <- a
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
264
	}
Jeromy's avatar
Jeromy committed
265 266
	close(remoteAddrChan)
	/////////
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
267 268

	// try to get a connection to any addr
Jeromy's avatar
Jeromy committed
269
	connC, err := s.dialAddrs(ctx, p, remoteAddrChan)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
270
	if err != nil {
Jeromy's avatar
Jeromy committed
271
		logdial["error"] = err.Error()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
272 273 274 275 276 277 278 279
		return nil, err
	}
	logdial["netconn"] = lgbl.NetConn(connC)

	// ok try to setup the new connection.
	defer log.EventBegin(ctx, "swarmDialDoSetup", logdial, lgbl.NetConn(connC)).Done()
	swarmC, err := dialConnSetup(ctx, s, connC)
	if err != nil {
Jeromy's avatar
Jeromy committed
280
		logdial["error"] = err.Error()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
281 282 283 284 285 286 287 288
		connC.Close() // close the connection. didn't work out :(
		return nil, err
	}

	logdial["dial"] = "success"
	return swarmC, nil
}

289
func (s *Swarm) dialAddrs(ctx context.Context, p peer.ID, remoteAddrs <-chan ma.Multiaddr) (iconn.Conn, error) {
Jeromy's avatar
Jeromy committed
290
	log.Debugf("%s swarm dialing %s", s.local, p)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
291 292 293 294

	ctx, cancel := context.WithCancel(ctx)
	defer cancel() // cancel work when we exit func

Jeromy's avatar
Jeromy committed
295 296
	// use a single response type instead of errs and conns, reduces complexity *a ton*
	respch := make(chan dialResult)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
297

Jeromy's avatar
Jeromy committed
298 299
	defaultDialFail := fmt.Errorf("failed to dial %s (default failure)", p)
	exitErr := defaultDialFail
Jeromy's avatar
Jeromy committed
300

Jeromy's avatar
Jeromy committed
301 302
	var active int
	for {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
303
		select {
Jeromy's avatar
Jeromy committed
304 305 306 307 308 309 310
		case addr, ok := <-remoteAddrs:
			if !ok {
				remoteAddrs = nil
				if active == 0 {
					return nil, exitErr
				}
				continue
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
311 312
			}

Jeromy's avatar
Jeromy committed
313 314 315 316 317
			s.limitedDial(ctx, p, addr, respch)
			active++
		case <-ctx.Done():
			if exitErr == defaultDialFail {
				exitErr = ctx.Err()
Jeromy's avatar
Jeromy committed
318
			}
Jeromy's avatar
Jeromy committed
319 320 321 322
			return nil, exitErr
		case resp := <-respch:
			active--
			if resp.Err != nil {
Marten Seemann's avatar
Marten Seemann committed
323
				log.Infof("got error on dial to %s: %s", resp.Addr, resp.Err)
Jeromy's avatar
Jeromy committed
324 325 326 327 328 329 330 331
				// Errors are normal, lots of dials will fail
				exitErr = resp.Err

				if remoteAddrs == nil && active == 0 {
					return nil, exitErr
				}
			} else if resp.Conn != nil {
				return resp.Conn, nil
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
332 333 334
			}
		}
	}
Jeromy's avatar
Jeromy committed
335 336
}

Jeromy's avatar
Jeromy committed
337 338 339
// limitedDial will start a dial to the given peer when
// it is able, respecting the various different types of rate
// limiting that occur without using extra goroutines per addr
Jeromy's avatar
Jeromy committed
340 341 342 343 344 345 346
func (s *Swarm) limitedDial(ctx context.Context, p peer.ID, a ma.Multiaddr, resp chan dialResult) {
	s.limiter.AddDialJob(&dialJob{
		addr: a,
		peer: p,
		resp: resp,
		ctx:  ctx,
	})
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
347 348
}

349
func (s *Swarm) dialAddr(ctx context.Context, p peer.ID, addr ma.Multiaddr) (iconn.Conn, error) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
350 351
	log.Debugf("%s swarm dialing %s %s", s.local, p, addr)

Jeromy's avatar
Jeromy committed
352
	connC, err := s.dialer.Dial(ctx, addr, p)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
353 354 355 356 357 358 359 360
	if err != nil {
		return nil, fmt.Errorf("%s --> %s dial attempt failed: %s", s.local, p, err)
	}

	// if the connection is not to whom we thought it would be...
	remotep := connC.RemotePeer()
	if remotep != p {
		connC.Close()
361 362
		_, err := connC.Read(nil) // should return any potential errors (ex: from secio)
		return nil, fmt.Errorf("misdial to %s through %s (got %s): %s", p, addr, remotep, err)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
363 364 365 366 367 368 369 370 371 372 373 374 375 376
	}

	// if the connection is to ourselves...
	// this can happen TONS when Loopback addrs are advertized.
	// (this should be caught by two checks above, but let's just make sure.)
	if remotep == s.local {
		connC.Close()
		return nil, fmt.Errorf("misdial to %s through %s (got self)", p, addr)
	}

	// success! we got one!
	return connC, nil
}

377 378
var ConnSetupTimeout = time.Minute * 5

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
379 380
// dialConnSetup is the setup logic for a connection from the dial side. it
// needs to add the Conn to the StreamSwarm, then run newConnSetup
381
func dialConnSetup(ctx context.Context, s *Swarm, connC iconn.Conn) (*Conn, error) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
382

383 384 385 386 387 388 389 390 391
	deadline, ok := ctx.Deadline()
	if !ok {
		deadline = time.Now().Add(ConnSetupTimeout)
	}

	if err := connC.SetDeadline(deadline); err != nil {
		return nil, err
	}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
392 393 394 395 396 397 398 399 400 401 402 403 404
	psC, err := s.swarm.AddConn(connC)
	if err != nil {
		// connC is closed by caller if we fail.
		return nil, fmt.Errorf("failed to add conn to ps.Swarm: %s", err)
	}

	// ok try to setup the new connection. (newConnSetup will add to group)
	swarmC, err := s.newConnSetup(ctx, psC)
	if err != nil {
		psC.Close() // we need to make sure psC is Closed.
		return nil, err
	}

405 406 407 408 409
	if err := connC.SetDeadline(time.Time{}); err != nil {
		log.Error("failed to reset connection deadline after setup: ", err)
		return nil, err
	}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
410 411
	return swarmC, err
}