Merge pull request #131 from libp2p/fix/noisy

logging: make the swarm less noisy

swarm.go

@@ -116,6 +116,11 @@ func NewSwarm(ctx context.Context, local peer.ID, peers peerstore.Peerstore, bwc
 }
 
 func (s *Swarm) teardown() error {
+	// Wait for the context to be canceled.
+	// This allows other parts of the swarm to detect that we're shutting
+	// down.
+	<-s.ctx.Done()
+
 	// Prevents new connections and/or listeners from being added to the swarm.
 
 	s.listeners.Lock()

swarm_listen.go

@@ -79,6 +79,7 @@ func (s *Swarm) AddListenAddr(a ma.Multiaddr) error {
 			c, err := list.Accept()
 			if err != nil {
 				if s.ctx.Err() == nil {
+					// only log if the swarm is still running.
 					log.Errorf("swarm listener accept error: %s", err)
 				}
 				return
@@ -88,9 +89,13 @@ func (s *Swarm) AddListenAddr(a ma.Multiaddr) error {
 			go func() {
 				defer s.refs.Done()
 				_, err := s.addConn(c, network.DirInbound)
-				if err != nil {
-					// Probably just means that the swarm has been closed.
-					log.Warningf("add conn failed: ", err)
+				switch err {
+				case nil:
+				case ErrSwarmClosed:
+					// ignore.
+					return
+				default:
+					log.Warningf("add conn %s failed: ", err)
 					return
 				}
 			}()