GitLab

fix(nat): use the right addresses when nat port mapping

chore: update deps

We switched `listenAddrs` from the _interface_ addresses to the raw addresses we
were listening on. Unfortunately, we needed the resolved addresses later in the
function when resolving port mappings.

* Updates yamux to reduce lock contention.
* Updates the peerstore to remove an issue where we'd forget our peer's addresses instead of extending the TTL.

Fix peer handler race

Alternative to #963. Instead of using atomics, this patch ensures that all state
changes are performed on the main thread. It also:

* Threads the context through explicitly to make sure fields changed by the main
thread are never read by the handler goroutines. This isn't strictly necessary
but it makes it easier to reason about.
* Uses a callback to signal "on done". There may be cleaner ways to do this (I
hate callbacks), but this nicely decouples the peer handler from the main loop.

fixes #963

optimize numInbound count

We call this _very_ frequently when computing our local addresses.

We prefer addresses from inbound connections. We don't want outbound connections
to hide these perfectly good addresses.

We don't use and/or expose these anyways. Making them private makes it easier to
reason about their state.

update go-libp2p-circuit

Chunking large Identify responses with Signed Records

We no longer need it now that we keep reading till the stream closes.

gomod: update dependencies

go-libp2p-core@v0.5.7
go-libp2p-connmgr@v0.2.4 [indirect]
go-eventbus@v0.2.1

* Filter Host Addresses

fix: remove old addresses in identify immediately

Previously, we'd keep addresses discovered through the DHT for up to 2
minutes (temporary TTL) and previously seen addresses (recently connected) for
up to 10 minutes (the TTL).

1. Make sure to downgrade both connected and recently connected addresses to the
"temporary" ttl before adding new addresses.
2. Finally, downgrade addresses with the temporary TTL to 0.

This could be more efficient with a better peerstore abstraction, but this is
better than nothing.

Fix flaky TestIdentifyPushOnAddrChange

fix: group observations by zeroing port

In #917, we started dropping additional address observations if we had multiple
for the same transport set. However, on further consideration, this isn't quite
correct. We _want_ to keep additional observations for multiple IP addresses.
The real issue is many observations for different ports.

So this patch simply changes the key with which we group observations from
"address protocols" to "address without the port" (well, with the port set to
0).

fix: fix connection gater in transport constructor

Fix potential flakiness in TestIDService

* filter observed addrs

fix: don't try to marshal a nil record

fixes #939