GitLab

We call this _very_ frequently when computing our local addresses.

We prefer addresses from inbound connections. We don't want outbound connections
to hide these perfectly good addresses.

We don't use and/or expose these anyways. Making them private makes it easier to
reason about their state.

Chunking large Identify responses with Signed Records

We no longer need it now that we keep reading till the stream closes.

gomod: update dependencies

go-libp2p-core@v0.5.7
go-libp2p-connmgr@v0.2.4 [indirect]
go-eventbus@v0.2.1

* Filter Host Addresses

fix: remove old addresses in identify immediately

Previously, we'd keep addresses discovered through the DHT for up to 2
minutes (temporary TTL) and previously seen addresses (recently connected) for
up to 10 minutes (the TTL).

1. Make sure to downgrade both connected and recently connected addresses to the
"temporary" ttl before adding new addresses.
2. Finally, downgrade addresses with the temporary TTL to 0.

This could be more efficient with a better peerstore abstraction, but this is
better than nothing.

Fix flaky TestIdentifyPushOnAddrChange

fix: group observations by zeroing port

In #917, we started dropping additional address observations if we had multiple
for the same transport set. However, on further consideration, this isn't quite
correct. We _want_ to keep additional observations for multiple IP addresses.
The real issue is many observations for different ports.

So this patch simply changes the key with which we group observations from
"address protocols" to "address without the port" (well, with the port set to
0).

fix: fix connection gater in transport constructor

Fix potential flakiness in TestIDService

* filter observed addrs

fix: don't try to marshal a nil record

fixes #939

add test to demo missing peer records after listen

fix: don't leak a goroutine if a peer connects and immediately disconnects

* Disable generation of Signed peer record for Mockenets.

* various identify fixes and nits
Co-authored-by: Aarsh Shah <aarshkshah1992@gmail.com>