Commits · 02fca42a69942442f76527c94669d1da11017d0c · dms3 / go-bitswap

18 Dec, 2014 38 commits
- refactor: re-use wantlist.Entry type wherever it makes sense · 02fca42a
  Brian Tiger Chow authored Dec 16, 2014
```
it seems to make sense since, in each place, the Key and Priority
represent the same information

b/c you know the saying...

"It is better to have 100 functions operate on one data structure than
10 functions on 10 data structures."

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  02fca42a
- doc: add comment to Envelope · b527a68b
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  b527a68b
- privatize Task · cc677a40
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  cc677a40
- tq.Cancel -> tq.Remove · 404ac1d2
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  404ac1d2
- it's not a queue yet but it's okay to name it as such · c93269ee
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  c93269ee
- perf: avoid lots of communication by signaling once at end of method · fcaf7f56
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  fcaf7f56
- add comment to fix race · c8e48477
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  c8e48477
- refactor: remove peerKey type · 98fe773a
  Brian Tiger Chow authored Dec 16, 2014
```
we've been using maps with peers long enough now that this probably is
no longer necessary

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  98fe773a
- unexport task and taskList · 37a5fc29
  Brian Tiger Chow authored Dec 16, 2014
```
the less bitswap has to know about, the easier it'll be for readers.
(This now returns Messages.)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  37a5fc29
- refactor: taskKey := p.Key() + block.Key() · e84b37a7
  Brian Tiger Chow authored Dec 16, 2014
```
for clarity and to avoid errors, define a function

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  e84b37a7
- doc: comment · 7aa16ef2
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  7aa16ef2
- refactor: context first in argument list · 997165aa
  Brian Tiger Chow authored Dec 16, 2014
```
(merely by convention)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  997165aa
- fix: move the check into the function. · 2b07d00f
  Brian Tiger Chow authored Dec 16, 2014
```
function should be a no-op when passed an empty slice

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  2b07d00f
- refactor: avoid loop reuse · 33d8110e
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  33d8110e
- refactor: change Tasks to Outbox · 9069a8aa
  Brian Tiger Chow authored Dec 16, 2014
```
notice that moving the blockstore fetch into the manager removes the
weird error handling case.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  9069a8aa
- style constify variables · f03e629f
  Brian Tiger Chow authored Dec 16, 2014
```
good to const until it's required for them to be variable.

TODO pass them in as configuration options
```
  f03e629f
- fix: move to callsite so public callers don't experience the internal timeout rule · bf61c8ce
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  bf61c8ce
- style: line wrapping · 6d88f9aa
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  6d88f9aa
- fix(test): nil Blockstore · 9fac2f30
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  9fac2f30
- refactor peerSet · b88f0394
  Jeromy authored Dec 16, 2014
  
  b88f0394
- avoid attaching context to object when it's not necessary. · 211fa238
  Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  211fa238
- name findOrCreate · 365f43ad
  Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  365f43ad
- queue-like naming · 66c94d77
  Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  66c94d77
- remove dead code · 7071ef57
  Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  7071ef57
- refactor() message API · fe040f76
  Brian Tiger Chow authored Dec 15, 2014
```
performing CR in the form of a PR. Let me know what you think.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  fe040f76
- some cleanup before CR · 17d40121
  Jeromy authored Dec 16, 2014
  
  17d40121
- renaming and removing empty strategy file · 130391c7
  Jeromy authored Dec 16, 2014
  
  130391c7
- tasklist queue for bitswap tasks · 8fe456ba
  Jeromy authored Dec 16, 2014
  
  8fe456ba
- rewrite sendWantlistToProviders · e6a504fd
  Jeromy authored Dec 15, 2014
  
  e6a504fd
- add locks to wantlist to avoid race condition · 061f0d39
  Jeromy authored Dec 14, 2014
  
  061f0d39
- remove noisy statement · 4b4958e3
  Brian Tiger Chow authored Dec 13, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  4b4958e3
- blockstore.ErrNotFound, and proper wantlist sorting · ac563d76
  Jeromy authored Dec 10, 2014
  
  ac563d76
- add priorities to GetBlocks requests, and add waitgroup to sendWantListTo · 70c89ffb
  Jeromy authored Dec 10, 2014
  
  70c89ffb
- dont spawn so many goroutines when rebroadcasting wantlist · 13f98cb1
  Jeromy authored Dec 10, 2014
  
  13f98cb1
- extracted ledgerset from strategy, cleaned up a few comments from the PR · 3818c938
  Jeromy authored Dec 10, 2014
  
  3818c938
- implement bitswap roundWorker · ade18f0c
  Jeromy authored Dec 10, 2014
```
make vendor
```
  ade18f0c
- create wantlist object · e92ee20e
  Jeromy authored Dec 10, 2014
  
  e92ee20e
- make vendor · b3f309a9
  Juan Batiz-Benet authored Dec 16, 2014
  
  b3f309a9
16 Dec, 2014 1 commit
- Integrated new network into ipfs · 6cebf01b
  Juan Batiz-Benet authored Dec 16, 2014
  
  6cebf01b
15 Dec, 2014 1 commit

doc TODO · 68ae22c6

Brian Tiger Chow authored Dec 14, 2014

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>

68ae22c6