Commits · 02fca42a69942442f76527c94669d1da11017d0c · dms3 / go-bitswap

18 Dec, 2014 25 commits
- refactor: re-use wantlist.Entry type wherever it makes sense · 02fca42a
  Brian Tiger Chow authored Dec 16, 2014
```
it seems to make sense since, in each place, the Key and Priority
represent the same information

b/c you know the saying...

"It is better to have 100 functions operate on one data structure than
10 functions on 10 data structures."

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  02fca42a
- doc: add comment to Envelope · b527a68b
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  b527a68b
- privatize Task · cc677a40
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  cc677a40
- tq.Cancel -> tq.Remove · 404ac1d2
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  404ac1d2
- it's not a queue yet but it's okay to name it as such · c93269ee
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  c93269ee
- perf: avoid lots of communication by signaling once at end of method · fcaf7f56
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  fcaf7f56
- add comment to fix race · c8e48477
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  c8e48477
- refactor: remove peerKey type · 98fe773a
  Brian Tiger Chow authored Dec 16, 2014
```
we've been using maps with peers long enough now that this probably is
no longer necessary

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  98fe773a
- unexport task and taskList · 37a5fc29
  Brian Tiger Chow authored Dec 16, 2014
```
the less bitswap has to know about, the easier it'll be for readers.
(This now returns Messages.)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  37a5fc29
- refactor: taskKey := p.Key() + block.Key() · e84b37a7
  Brian Tiger Chow authored Dec 16, 2014
```
for clarity and to avoid errors, define a function

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  e84b37a7
- doc: comment · 7aa16ef2
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  7aa16ef2
- refactor: context first in argument list · 997165aa
  Brian Tiger Chow authored Dec 16, 2014
```
(merely by convention)

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  997165aa
- refactor: change Tasks to Outbox · 9069a8aa
  Brian Tiger Chow authored Dec 16, 2014
```
notice that moving the blockstore fetch into the manager removes the
weird error handling case.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  9069a8aa
- fix(test): nil Blockstore · 9fac2f30
  Brian Tiger Chow authored Dec 16, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  9fac2f30
- avoid attaching context to object when it's not necessary. · 211fa238
  Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  211fa238
- name findOrCreate · 365f43ad
  Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  365f43ad
- queue-like naming · 66c94d77
  Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  66c94d77
- remove dead code · 7071ef57
  Brian Tiger Chow authored Dec 15, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  7071ef57
- refactor() message API · fe040f76
  Brian Tiger Chow authored Dec 15, 2014
```
performing CR in the form of a PR. Let me know what you think.

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  fe040f76
- some cleanup before CR · 17d40121
  Jeromy authored Dec 16, 2014
  
  17d40121
- renaming and removing empty strategy file · 130391c7
  Jeromy authored Dec 16, 2014
  
  130391c7
- tasklist queue for bitswap tasks · 8fe456ba
  Jeromy authored Dec 16, 2014
  
  8fe456ba
- blockstore.ErrNotFound, and proper wantlist sorting · ac563d76
  Jeromy authored Dec 10, 2014
  
  ac563d76
- extracted ledgerset from strategy, cleaned up a few comments from the PR · 3818c938
  Jeromy authored Dec 10, 2014
  
  3818c938
- implement bitswap roundWorker · ade18f0c
  Jeromy authored Dec 10, 2014
```
make vendor
```
  ade18f0c
13 Dec, 2014 1 commit
- misc(bitswap/strat) rm noisy message · 33ae9d43
  Brian Tiger Chow authored Dec 13, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  33ae9d43
08 Dec, 2014 2 commits
- fix(core, peer) helpers to testutil, err handling · 011cb28d
  Brian Tiger Chow authored Dec 08, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  011cb28d
- refactor(peer): create peer through peerstore · 8bff08bd
  Brian Tiger Chow authored Dec 08, 2014
```
for safety!

use mockpeer.WithID methods to create peers in tests

License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  8bff08bd
07 Dec, 2014 3 commits
- log when dupe block is prevented · a48e70f9
  Jeromy authored Dec 07, 2014
  
  a48e70f9
- same block cant be sent twice to a peer within a certain time period · 29aa7547
  Jeromy authored Dec 07, 2014
  
  29aa7547
- prevent sending of same block to a peer twice · 13ab516c
  Jeromy authored Dec 07, 2014
  
  13ab516c
05 Dec, 2014 6 commits
- some bitswap cleanup · 15a7d870
  Jeromy authored Nov 26, 2014
  
  15a7d870
- a little more correctness on the new bitswap impl · 92e2d247
  Jeromy authored Nov 21, 2014
  
  92e2d247
- wire GetBlocks into blockservice · b5121d63
  Jeromy authored Nov 21, 2014
  
  b5121d63
- randomize rebroadcast target · 6ee1fe5e
  Jeromy authored Nov 20, 2014
  
  6ee1fe5e
- move some variables into strategy · c6af3fe4
  Jeromy authored Nov 19, 2014
  
  c6af3fe4
- clarify MessageReceived contract · a82ac0a9
  Brian Tiger Chow authored Nov 18, 2014
```
License: MIT
Signed-off-by: Brian Tiger Chow <brian@perfmode.com>
```
  a82ac0a9
28 Oct, 2014 2 commits
- style(bitswap/message) rename method -> AddBlock · 8cd17e8d
  Brian Tiger Chow authored Oct 27, 2014
```
to emphasize idempotence
```
  8cd17e8d
- style(bitswap/message) rename AppendWanted -> AddWanted · 6db72127
  Brian Tiger Chow authored Oct 27, 2014
```
implementation will be patched to ensure bitswap messages cannot contain
duplicate blocks or keys
```
  6db72127
25 Oct, 2014 1 commit
- style(bitswap) import · ba0d68c0
  Brian Tiger Chow authored Oct 24, 2014
  
  ba0d68c0