1. 21 May, 2015 1 commit
  2. 20 May, 2015 2 commits
    • Knut Ahlers's avatar
      Fix: Using the `dnslink` feature led to infinite redirects · 1b379747
      Knut Ahlers authored
      fixes #1233
      1b379747
    • W. Trevor King's avatar
      namesys: Add recursive resolution · 3ead2443
      W. Trevor King authored
      This allows direct access to the earlier protocol-specific Resolve
      implementations.  The guts of each protocol-specific resolver are in
      the internal resolveOnce method, and we've added a new:
      
        ResolveN(ctx, name, depth)
      
      method to the public interface.  There's also:
      
        Resolve(ctx, name)
      
      which wraps ResolveN using DefaultDepthLimit.  The extra API endpoint
      is intended to reduce the likelyhood of clients accidentally calling
      the more dangerous ResolveN with a nonsensically high or infinite
      depth.  On IRC on 2015-05-17, Juan said:
      
      15:34 <jbenet> If 90% of uses is the reduced API with no chance to
        screw it up, that's a huge win.
      15:34 <wking> Why would those 90% not just set depth=0 or depth=1,
        depending on which they need?
      15:34 <jbenet> Because people will start writing `r.Resolve(ctx, name,
        d)` where d is a variable.
      15:35 <wking> And then accidentally set that variable to some huge
        number?
      15:35 <jbenet> Grom experience, i've seen this happen _dozens_ of
        times. people screw trivial things up.
      15:35 <wking> Why won't those same people be using ResolveN?
      15:36 <jbenet> Because almost every example they see will tell them to
        use Resolve(), and they will mostly stay away from ResolveN.
      
      The per-prodocol versions also resolve recursively within their
      protocol.  For example:
      
        DNSResolver.Resolve(ctx, "ipfs.io", 0)
      
      will recursively resolve DNS links until the referenced value is no
      longer a DNS link.
      
      I also renamed the multi-protocol ipfs NameSystem (defined in
      namesys/namesys.go) to 'mpns' (for Multi-Protocol Name System),
      because I wasn't clear on whether IPNS applied to the whole system or
      just to to the DHT-based system.  The new name is unambiguously
      multi-protocol, which is good.  It would be nice to have a distinct
      name for the DHT-based link system.
      
      Now that resolver output is always prefixed with a namespace and
      unprefixed mpns resolver input is interpreted as /ipfs/,
      core/corehttp/ipns_hostname.go can dispense with it's old manual
      /ipfs/ injection.
      
      Now that the Resolver interface handles recursion, we don't need the
      resolveRecurse helper in core/pathresolver.go.  The pathresolver
      cleanup also called for an adjustment to FromSegments to more easily
      get slash-prefixed paths.
      
      Now that recursive resolution with the namesys/namesys.go composite
      resolver always gets you to an /ipfs/... path, there's no need for the
      /ipns/ special case in fuse/ipns/ipns_unix.go.
      
      Now that DNS links can be things other than /ipfs/ or DHT-link
      references (e.g. they could be /ipns/<domain-name> references) I've
      also loosened the ParsePath logic to only attempt multihash validation
      on IPFS paths.  It checks to ensure that other paths have a
      known-protocol prefix, but otherwise leaves them alone.
      
      I also changed some key-stringification from .Pretty() to .String()
      following the potential deprecation mentioned in util/key.go.
      3ead2443
  3. 18 May, 2015 1 commit
  4. 10 May, 2015 2 commits
  5. 09 May, 2015 4 commits
  6. 08 May, 2015 1 commit
    • Henry's avatar
      core: add context.Context param to core.Resolve() · f640ba00
      Henry authored
      commands/object: remove objectData() and objectLinks() helpers
      resolver: added context parameters
      sharness: $HASH carried the \r from the http protocol with
      sharness: write curl output to individual files
      http gw: break PUT handler until PR#1191
      f640ba00
  7. 02 May, 2015 1 commit
  8. 27 Apr, 2015 2 commits
  9. 20 Apr, 2015 4 commits
    • Tor Arne Vestbø's avatar
      corehttp: disable HTTP keep-alive when shutting down server · 6fe85496
      Tor Arne Vestbø authored
      Once the server is asked to shut down, we stop accepting new
      connections, but the 'manners' graceful shutdown will wait for
      all existing connections closed to close before finishing.
      
      For keep-alive connections this will never happen unless the
      client detects that the server is shutting down through the
      ipfs API itself, and closes the connection in response.
      
      This is a problem e.g. with the webui's connections visualization,
      which polls the swarm/peers endpoint once a second, and never
      detects that the API server was shut down.
      
      We can mitigate this by telling the server to disable keep-alive,
      which will add a 'Connection: close' header to the next HTTP
      response on the connection. A well behaving client should then
      treat that correspondingly by closing the connection.
      
      Unfortunately this doesn't happen immediately in all cases,
      presumably depending on the keep-alive timeout of the browser
      that set up the connection, but it's at least a step in the
      right direction.
      6fe85496
    • Tor Arne Vestbø's avatar
      corehttp: ensure node closing/teardown waits for server termination · c9d30849
      Tor Arne Vestbø authored
      When closing a node, the node itself only takes care of tearing down
      its own children. As corehttp sets up a server based on a node, it
      needs to also ensure that the server is accounted for when determining
      if the node has been fully closed.
      c9d30849
    • Tor Arne Vestbø's avatar
      corehttp: log when server takes a long time to shut down · cc830ff2
      Tor Arne Vestbø authored
      The server may stay alive for quite a while due to waiting on
      open connections to close before shutting down. We should
      find ways to terminate these connections in a more controlled
      manner, but in the meantime it's helpful to be able to see
      why a shutdown of the ipfs daemon is taking so long.
      cc830ff2
    • Jeromy's avatar
      fix for #1008 and other pinning fixes · 0a6b880b
      Jeromy authored
      This commit adds a new set of sharness tests for pinning, and addresses
      bugs that were pointed out by said tests.
      
      test/sharness: added more pinning tests
      
      Pinning is currently broken. See issue #1051. This commit introduces
      a few more pinning tests. These are by no means exhaustive, but
      definitely surface the present problems going on. I believe these
      tests are correct, but not sure. Pushing them as failing so that
      pinning is fixed in this PR.
      
      make pinning and merkledag.Get take contexts
      
      improve 'add' commands usage of pinning
      
      FIXUP: fix 'pin lists look good'
      
      ipfs-pin-stat simple script to help check pinning
      
      This is a simple shell script to help check pinning.
      
      We ought to strive towards making adding commands this easy.
      The http api is great and powerful, but our setup right now
      gets in the way. Perhaps we can clean up that area.
      
      updated t0081-repo-pinning
      
      - fixed a couple bugs with the tests
      - made it a bit clearer (still a lot going on)
      - the remaining tests are correct and highlight a problem with
        pinning. Namely, that recursive pinning is buggy. At least:
        towards the end of the test, $HASH_DIR4 and $HASH_FILE4 should
        be pinned indirectly, but they're not. And thus get gc-ed out.
        There may be other problems too.
      
      cc @whyrusleeping
      
      fix grep params for context deadline check
      
      fix bugs in pin and pin tests
      
      check for block local before checking recursive pin
      0a6b880b
  10. 12 Apr, 2015 1 commit
  11. 31 Mar, 2015 1 commit
  12. 16 Mar, 2015 2 commits
  13. 03 Mar, 2015 1 commit
  14. 02 Mar, 2015 1 commit
  15. 25 Feb, 2015 1 commit
    • Henry's avatar
      rewrote import paths of go.net/context to use golang.org/x/context · 92d08db7
      Henry authored
      - updated go-ctxgroup and goprocess
      ctxgroup: AddChildGroup was changed to AddChild. Used in two files:
      - p2p/net/mock/mock_net.go
      - routing/dht/dht.go
      
      - updated context from hg repo to git
      prev. commit in hg was ad01a6fcc8a19d3a4478c836895ffe883bd2ceab. (context: make parentCancelCtx iterative)
      represents commit 84f8955a887232b6308d79c68b8db44f64df455c in git repo
      
      - updated context to master (b6fdb7d8a4ccefede406f8fe0f017fb58265054c)
      
      Aaron Jacobs (2):
      net/context: Don't accept a context in the DoSomethingSlow example.
      context: Be clear that users must cancel the result of WithCancel.
      
      Andrew Gerrand (1):
      go.net: use golang.org/x/... import paths
      
      Bryan C. Mills (1):
      net/context: Don't leak goroutines in Done example.
      
      Damien Neil (1):
      context: fix removal of cancelled timer contexts from parent
      
      David Symonds (2):
      context: Fix WithValue example code.
      net: add import comments.
      
      Sameer Ajmani (1):
      context: fix TestAllocs to account for ints in interfaces
      92d08db7
  16. 20 Feb, 2015 1 commit
  17. 16 Feb, 2015 2 commits
  18. 08 Feb, 2015 4 commits
  19. 07 Feb, 2015 1 commit
    • Juan Batiz-Benet's avatar
      gateway: dont cache ipns paths · 872c64dd
      Juan Batiz-Benet authored
      ipns paths are mutable and should not be cached. this error is
      a byproduct of the currently messy gateway route. We should split
      the /ipfs and /ipns routes up.
      872c64dd
  20. 06 Feb, 2015 2 commits
  21. 05 Feb, 2015 5 commits