- 16 Nov, 2017 3 commits
-
-
Steven Allen authored
We'll need these for slower/remote datastores.
-
Steven Allen authored
-
Steven Allen authored
The caller can just call `node.Cid()` and returning CIDs from `AddMany` requires allocation.
-
- 15 Nov, 2017 1 commit
-
-
Steven Allen authored
1. Add is already idempotent. This makes remove match. 2. Generally, all we care about is that the node no longer exists in the DAG. If two callers remove a node at the same time, they should both succeed. Currently, we *ignore* the result of Remove in go-ipfs. IMO, it would be better to let errors be *errors* and only return an error if something goes wrong. 3. This can be significantly faster. It allows us to batch/queue removes (as long as we guarantee that they'll eventually happen). 4. This matches how most databases/key-value stores operate. An alternative would be to return `(deleted bool, err error)` but then we don't get the speedup.
-
- 16 Oct, 2017 10 commits
-
-
Steven Allen authored
It really just doesn't fit. We're working on making this method obsolete anyways.
-
Steven Allen authored
Keep merkledag clean.
-
Steven Allen authored
This will allow many consumers of `DAGService` to take `NodeGetter` instead and implementing `GetMany` for all `NodeGetter`s is pretty trivial.
-
Steven Allen authored
We're going to want to do this eventually and we have to refactor anyways so we might as well do this now. Fixes ipfs/go-ipfs#4010
-
Steven Allen authored
-
Steven Allen authored
We'll just live with this name.
-
Steven Allen authored
-
Steven Allen authored
This way, not *all* DAGServices need to implement this interface, they can just implement it as an optimization.
-
Steven Allen authored
-
Steven Allen authored
This is a WIP/RFC attempt at extracting DAGService from go-ipfs.
-