- 25 May, 2021 2 commits
-
-
Eric Myhre authored
Add enumerate methods to the multicodec registries.
-
Eric Myhre authored
Make a multicodec.Registry type available.
-
- 24 May, 2021 2 commits
-
-
Will Scott authored
(This is a logical port of https://github.com/ipld/go-ipld-prime/pull/169 to follow https://github.com/ipld/go-ipld-prime/pull/172 .) I've added more documentation -- particularly, cautionary notes on the package-scope functions which read the global shared state.
-
Eric Myhre authored
The hope is that this might be helpful if you want to build a multicodec registry other than the global one, but are still buying into the idea of the registry being keyed by indicator numbers. (I'm... not actually sure how useful this is, because I'd think if you're building something other than the default, there's also a good chance you'd want *more* features than a primitive numerical mapping, which are probably going to be related to whatever your application logic in the area is, and therefore not possible for this library to usefully anticipate. But, I dunno. I'm doing this because people are proposing attaching more features to the global, and I'm not comfortable with it, and I'm hoping this will provide a pressure release valve.) The current interfaces are functionally unchanged. The multicodec.Registry type can now be used when constructing a cidlink.LinkSystem. (This saves you from having to write the glue functions to unbox cidlink and then do the LookupEncoder and LookupDecode calls.) For where this relates to LinkSystem, I considered a mechanism like: `func (r *Registry) InstallOn(lsys *ipld.LinkSystem)` ... and probably would've found that a bit cleaner. However, it doesn't jive with the way we've isolated the CID types into a package with a LinkSystem just for them (sigh; that really is the gift of complexity that just keeps giving); you can see how the EncoderChooser and DecoderChooser funcs need a tiny bit of type assertions in order to figure out how to extract the multicodec indicator from the Link/LinkPrototype types? That bit is a bit that we still want to keep cordoned off the rest of the import tree. DefaultRegistry is also now an exported variable, in addition to the functions which already worked with the global data. I probably would've preferred to keep the DefaultRegistry variable unexported, because I can't imagine any good coming of touching it, but the relationship to LinkSystem detailed in the above paragraph requires some access to it.
-
- 05 May, 2021 1 commit
-
-
Daniel Martí authored
Since qp uses panics as an error mechanism, the top-level functions recover those errors to return them normally. However, this blows up if, internally, an ipld.Node implementation panics with a value whose type is not error. For example, with: panic("some panic message") One gets: panic: some panic message [recovered] panic: interface conversion: string is not error: missing method Error Fix this by having a fallback for non-error panic values.
-
- 28 Apr, 2021 2 commits
-
-
Will authored
Allow emitting & parsing of bytes per dagjson codec spec
-
Will Scott authored
-
- 26 Apr, 2021 1 commit
-
-
Will Scott authored
fix #165
-
- 25 Apr, 2021 2 commits
-
-
Eric Myhre authored
These are somewhat overdue, and clarify what features are supported, and also note some discrepancies in implementation versus the spec. (As I'm taking this inventory of discrepancies, there's admittedly rather more than I'd like... but step 1: document the current truth. Prioritizing which things to hack on, in the field of infinite possible prioritizations of things that need hacking on, can be a step 2.)
-
Eric Myhre authored
These had drifted a bit, and I just noticed it's due for some freshening up.
-
- 19 Apr, 2021 1 commit
-
-
Eric Myhre authored
schema/gen/go: apply gofmt automatically
-
- 09 Apr, 2021 4 commits
-
-
Daniel Martí authored
Now that we buffer the output, using go/format is trivial. This makes the default behavior better, and means not having to use an extra gofmt go:generate step everywhere.
-
Daniel Martí authored
And re-generate all code in this module. This gets us to a point where go-codec-dagpb has zero vet warnings, for example. schema/dmt still has a few warnings, but those are trickier to fix, so will require another PR.
-
Eric Myhre authored
schema/gen/go: batch file writes via a bytes.Buffer
-
Daniel Martí authored
With this change, running 'go generate ./...' on the entire module while running gopls on one of its files drops gopls's CPU spinning from ~25s to well under a second. They should improve that anyway, but there's no reason for the tens of thousands of tiny FS writes on our end either. The time to run 'go generate ./...' itself is largely unaffected; it goes from ~1.2s to ~1.1s, judging by a handful of runs.
-
- 07 Apr, 2021 1 commit
-
-
Daniel Martí authored
If we know that a schema type can be represented in Go with a small amount of bytes, using a pointer to store its "maybe" is rarely a good idea. For example, an optional string only weighs twice as much as a pointer, so a pointer adds overhead and will barely ever save any memory. Add a function to work out the byte size of a schema.TypeKind, relying on reflection and the basicnode package. Debug prints are also present if one wants to double-check the numbers. As of today, they are: sizeOf(small): 32 (4x pointer size) sizeOf(Bool): 1 sizeOf(Int): 8 sizeOf(Float): 8 sizeOf(String): 16 sizeOf(Bytes): 24 sizeOf(List): 24 sizeOf(Map): 32 sizeOf(Link): 16 Below is the result on go-merkledag's BenchmarkRoundtrip after re-generating go-codec-dagpb with this change. Note that the dag-pb schema contains multiple optional fields, such as strings. name old time/op new time/op delta Roundtrip-8 4.24µs ± 3% 3.78µs ± 0% -10.87% (p=0.004 n=6+5) name old alloc/op new alloc/op delta Roundtrip-8 6.38kB ± 0% 6.24kB ± 0% -2.26% (p=0.002 n=6+6) name old allocs/op new allocs/op delta Roundtrip-8 103 ± 0% 61 ± 0% -40.78% (p=0.002 n=6+6) Schema typekinds which don't directly map to basicnode prototypes, such as structs and unions, are left as a TODO for now. I did not do any measurements to arrive at the magic number of 4x, which is documented in the code. We might well increase it in the future, with more careful benchmarking. For now, it seems like a conservative starting point that should cover all basic types. Finally, re-generate within this repo.
-
- 03 Apr, 2021 1 commit
-
-
Eric Myhre authored
-
- 02 Apr, 2021 1 commit
-
-
Eric Myhre authored
feat(linksystem): add reification to LinkSystem
-
- 01 Apr, 2021 1 commit
-
-
hannahhoward authored
add an optional reifier into the link system process. The reason to do this is to capture the link system itself when reification happens, in case it needs to be put into the node, which is often not accessible by the time you have a node. another alternative would be to make this specific to selector traversal, similar to LinkNodePrototypeChooser
-
- 24 Mar, 2021 2 commits
-
-
Eric Myhre authored
Add option to tell link system storage is trusted and we can skip hash on read
-
hannahhoward authored
Have boolean that specifies whether the storage is trusted. if it is, skip hashing on reads
-
- 23 Mar, 2021 5 commits
-
-
Eric Myhre authored
implement non-dag cbor codec
-
Will Scott authored
-
Eric Myhre authored
add non-dag json codec
-
Will Scott authored
-
Will Scott authored
-
- 22 Mar, 2021 1 commit
-
-
Will Scott authored
-
- 15 Mar, 2021 5 commits
-
-
Eric Myhre authored
:'(
-
Eric Myhre authored
-
Eric Myhre authored
-
Eric Myhre authored
This is just documenting our defacto policies already.
-
Eric Myhre authored
Unless we can keep these up to date with go-mod state automatically (and we don't currently have tools for that), maintaining both these systems is problematic.
-
- 12 Mar, 2021 8 commits
-
-
Eric Myhre authored
introduce LinkSystem
-
Eric Myhre authored
-
Eric Myhre authored
(It can be hard to intuit this just by reading the code, because some of the key relevance is actually in *other* functions that might not be in this repo at all!)
-
Eric Myhre authored
(Some things got better. Several others in the area still have not.)
-
hannahhoward authored
-
Eric Myhre authored
Resolves conflicts in go.sum. (They were conflicts in a textual sense only, but semantically trivial; application of `go mod tidy` was sufficient.)
-
Eric Myhre authored
-
Eric Myhre authored
I'm still not fully convinced this is always a win for performance, but as discussed in https://github.com/ipld/go-ipld-prime/pull/143#discussion_r582335774 , there was past evidence, and reproducing that takes work -- so, we're going to try to be relatively conservative here and keep this logical branch behavior in place for now. (The reason this may be worth re-examining is that the change to hashing interface probably gets rid of one big source of copies. That doens't answer the holistic performance question alone, though; it just reopens it.)
-