dht_test.go 33 KB
Newer Older
1 2
package dht

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
3
import (
4
	"bytes"
Jeromy's avatar
Jeromy committed
5
	"context"
6
	"errors"
7
	"fmt"
8
	"math/rand"
9
	"sort"
10
	"strings"
11
	"sync"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
12
	"testing"
13
	"time"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
14

15 16 17 18 19 20 21
	multistream "github.com/multiformats/go-multistream"

	"golang.org/x/xerrors"

	"github.com/stretchr/testify/assert"
	"github.com/stretchr/testify/require"

22 23
	opts "github.com/libp2p/go-libp2p-kad-dht/opts"
	pb "github.com/libp2p/go-libp2p-kad-dht/pb"
24

25
	cid "github.com/ipfs/go-cid"
26
	u "github.com/ipfs/go-ipfs-util"
27
	kb "github.com/libp2p/go-libp2p-kbucket"
28 29
	peer "github.com/libp2p/go-libp2p-peer"
	pstore "github.com/libp2p/go-libp2p-peerstore"
George Antoniadis's avatar
George Antoniadis committed
30
	record "github.com/libp2p/go-libp2p-record"
31
	routing "github.com/libp2p/go-libp2p-routing"
Steven Allen's avatar
Steven Allen committed
32
	swarmt "github.com/libp2p/go-libp2p-swarm/testing"
Jeromy's avatar
Jeromy committed
33
	bhost "github.com/libp2p/go-libp2p/p2p/host/basic"
George Antoniadis's avatar
George Antoniadis committed
34 35
	ci "github.com/libp2p/go-testutil/ci"
	travisci "github.com/libp2p/go-testutil/ci/travis"
36
	ma "github.com/multiformats/go-multiaddr"
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
37 38
)

39
var testCaseValues = map[string][]byte{}
40
var testCaseCids []cid.Cid
41 42 43 44

func init() {
	for i := 0; i < 100; i++ {
		v := fmt.Sprintf("%d -- value", i)
45 46 47

		mhv := u.Hash([]byte(v))
		testCaseCids = append(testCaseCids, cid.NewCidV0(mhv))
48 49 50
	}
}

51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80
type blankValidator struct{}

func (blankValidator) Validate(_ string, _ []byte) error        { return nil }
func (blankValidator) Select(_ string, _ [][]byte) (int, error) { return 0, nil }

type testValidator struct{}

func (testValidator) Select(_ string, bs [][]byte) (int, error) {
	index := -1
	for i, b := range bs {
		if bytes.Compare(b, []byte("newer")) == 0 {
			index = i
		} else if bytes.Compare(b, []byte("valid")) == 0 {
			if index == -1 {
				index = i
			}
		}
	}
	if index == -1 {
		return -1, errors.New("no rec found")
	}
	return index, nil
}
func (testValidator) Validate(_ string, b []byte) error {
	if bytes.Compare(b, []byte("expired")) == 0 {
		return errors.New("expired")
	}
	return nil
}

81
func setupDHT(ctx context.Context, t *testing.T, client bool) *IpfsDHT {
82 83
	d, err := New(
		ctx,
Steven Allen's avatar
Steven Allen committed
84
		bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)),
85 86 87 88 89
		opts.Client(client),
		opts.NamespacedValidator("v", blankValidator{}),
	)
	if err != nil {
		t.Fatal(err)
90
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
91 92 93
	return d
}

94
func setupDHTS(t *testing.T, ctx context.Context, n int) []*IpfsDHT {
95
	addrs := make([]ma.Multiaddr, n)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
96
	dhts := make([]*IpfsDHT, n)
97 98
	peers := make([]peer.ID, n)

99 100 101
	sanityAddrsMap := make(map[string]struct{})
	sanityPeersMap := make(map[string]struct{})

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
102
	for i := 0; i < n; i++ {
103
		dhts[i] = setupDHT(ctx, t, false)
104 105
		peers[i] = dhts[i].PeerID()
		addrs[i] = dhts[i].host.Addrs()[0]
106 107

		if _, lol := sanityAddrsMap[addrs[i].String()]; lol {
Jakub Sztandera's avatar
Jakub Sztandera committed
108
			t.Fatal("While setting up DHTs address got duplicated.")
109 110 111 112
		} else {
			sanityAddrsMap[addrs[i].String()] = struct{}{}
		}
		if _, lol := sanityPeersMap[peers[i].String()]; lol {
Jakub Sztandera's avatar
Jakub Sztandera committed
113
			t.Fatal("While setting up DHTs peerid got duplicated.")
114 115 116
		} else {
			sanityPeersMap[peers[i].String()] = struct{}{}
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
117 118
	}

119
	return dhts
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
120 121
}

122
func connectNoSync(t *testing.T, ctx context.Context, a, b *IpfsDHT) {
123 124
	t.Helper()

125
	idB := b.self
126
	addrB := b.peerstore.Addrs(idB)
127 128
	if len(addrB) == 0 {
		t.Fatal("peers setup incorrectly: no local address")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
129
	}
130

Jeromy's avatar
Jeromy committed
131 132
	a.peerstore.AddAddrs(idB, addrB, pstore.TempAddrTTL)
	pi := pstore.PeerInfo{ID: idB}
Jeromy's avatar
Jeromy committed
133
	if err := a.host.Connect(ctx, pi); err != nil {
134
		t.Fatal(err)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
135
	}
136 137
}

138 139
func wait(t *testing.T, ctx context.Context, a, b *IpfsDHT) {
	t.Helper()
140

141 142
	// loop until connection notification has been received.
	// under high load, this may not happen as immediately as we would like.
143
	for a.routingTable.Find(b.self) == "" {
144 145 146 147 148
		select {
		case <-ctx.Done():
			t.Fatal(ctx.Err())
		case <-time.After(time.Millisecond * 5):
		}
149
	}
150
}
151

152 153 154 155 156
func connect(t *testing.T, ctx context.Context, a, b *IpfsDHT) {
	t.Helper()
	connectNoSync(t, ctx, a, b)
	wait(t, ctx, a, b)
	wait(t, ctx, b, a)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
157 158
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
159
func bootstrap(t *testing.T, ctx context.Context, dhts []*IpfsDHT) {
160

161
	ctx, cancel := context.WithCancel(ctx)
Steven Allen's avatar
Steven Allen committed
162 163
	defer cancel()

Matt Joiner's avatar
Matt Joiner committed
164
	logger.Debugf("Bootstrapping DHTs...")
165 166 167 168 169 170

	// tried async. sequential fares much better. compare:
	// 100 async https://gist.github.com/jbenet/56d12f0578d5f34810b2
	// 100 sync https://gist.github.com/jbenet/6c59e7c15426e48aaedd
	// probably because results compound

171 172 173 174
	var cfg BootstrapConfig
	cfg = DefaultBootstrapConfig
	cfg.Queries = 3

175 176 177
	start := rand.Intn(len(dhts)) // randomize to decrease bias.
	for i := range dhts {
		dht := dhts[(start+i)%len(dhts)]
178
		dht.runBootstrap(ctx, cfg)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
179 180 181
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
182
func TestValueGetSet(t *testing.T) {
183 184
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
185

Steven Allen's avatar
Steven Allen committed
186
	var dhts [5]*IpfsDHT
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
187

Steven Allen's avatar
Steven Allen committed
188 189 190 191 192
	for i := range dhts {
		dhts[i] = setupDHT(ctx, t, false)
		defer dhts[i].Close()
		defer dhts[i].host.Close()
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
193

Steven Allen's avatar
Steven Allen committed
194
	connect(t, ctx, dhts[0], dhts[1])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
195

Steven Allen's avatar
Steven Allen committed
196
	t.Log("adding value on: ", dhts[0].self)
Jeromy's avatar
Jeromy committed
197 198
	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
Steven Allen's avatar
Steven Allen committed
199
	err := dhts[0].PutValue(ctxT, "/v/hello", []byte("world"))
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
200 201 202 203
	if err != nil {
		t.Fatal(err)
	}

Steven Allen's avatar
Steven Allen committed
204
	t.Log("requesting value on dhts: ", dhts[1].self)
Jeromy's avatar
Jeromy committed
205 206
	ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
	defer cancel()
Steven Allen's avatar
Steven Allen committed
207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247

	val, err := dhts[1].GetValue(ctxT, "/v/hello")
	if err != nil {
		t.Fatal(err)
	}

	if string(val) != "world" {
		t.Fatalf("Expected 'world' got '%s'", string(val))
	}

	// late connect

	connect(t, ctx, dhts[2], dhts[0])
	connect(t, ctx, dhts[2], dhts[1])

	t.Log("requesting value (offline) on dhts: ", dhts[2].self)
	vala, err := dhts[2].GetValue(ctxT, "/v/hello", Quorum(0))
	if vala != nil {
		t.Fatalf("offline get should have failed, got %s", string(vala))
	}
	if err != routing.ErrNotFound {
		t.Fatalf("offline get should have failed with ErrNotFound, got: %s", err)
	}

	t.Log("requesting value (online) on dhts: ", dhts[2].self)
	val, err = dhts[2].GetValue(ctxT, "/v/hello")
	if err != nil {
		t.Fatal(err)
	}

	if string(val) != "world" {
		t.Fatalf("Expected 'world' got '%s'", string(val))
	}

	for _, d := range dhts[:3] {
		connect(t, ctx, dhts[3], d)
	}
	connect(t, ctx, dhts[4], dhts[3])

	t.Log("requesting value (requires peer routing) on dhts: ", dhts[4].self)
	val, err = dhts[4].GetValue(ctxT, "/v/hello")
248 249 250 251
	if err != nil {
		t.Fatal(err)
	}

Steven Allen's avatar
Steven Allen committed
252 253
	if string(val) != "world" {
		t.Fatalf("Expected 'world' got '%s'", string(val))
254
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
255 256
}

257 258 259 260 261 262 263 264 265 266 267 268
func TestValueSetInvalid(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	dhtA := setupDHT(ctx, t, false)
	dhtB := setupDHT(ctx, t, false)

	defer dhtA.Close()
	defer dhtB.Close()
	defer dhtA.host.Close()
	defer dhtB.host.Close()

269
	dhtA.Validator.(record.NamespacedValidator)["v"] = testValidator{}
270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309
	dhtB.Validator.(record.NamespacedValidator)["v"] = blankValidator{}

	connect(t, ctx, dhtA, dhtB)

	testSetGet := func(val string, failset bool, exp string, experr error) {
		t.Helper()

		ctxT, cancel := context.WithTimeout(ctx, time.Second)
		defer cancel()
		err := dhtA.PutValue(ctxT, "/v/hello", []byte(val))
		if failset {
			if err == nil {
				t.Error("expected set to fail")
			}
		} else {
			if err != nil {
				t.Error(err)
			}
		}

		ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
		defer cancel()
		valb, err := dhtB.GetValue(ctxT, "/v/hello")
		if err != experr {
			t.Errorf("Set/Get %v: Expected %v error but got %v", val, experr, err)
		} else if err == nil && string(valb) != exp {
			t.Errorf("Expected '%v' got '%s'", exp, string(valb))
		}
	}

	// Expired records should not be set
	testSetGet("expired", true, "", routing.ErrNotFound)
	// Valid record should be returned
	testSetGet("valid", false, "valid", nil)
	// Newer record should supersede previous record
	testSetGet("newer", false, "newer", nil)
	// Attempt to set older record again should be ignored
	testSetGet("valid", true, "newer", nil)
}

Łukasz Magiera's avatar
Łukasz Magiera committed
310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336
func TestSearchValue(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	dhtA := setupDHT(ctx, t, false)
	dhtB := setupDHT(ctx, t, false)

	defer dhtA.Close()
	defer dhtB.Close()
	defer dhtA.host.Close()
	defer dhtB.host.Close()

	connect(t, ctx, dhtA, dhtB)

	dhtA.Validator.(record.NamespacedValidator)["v"] = testValidator{}
	dhtB.Validator.(record.NamespacedValidator)["v"] = testValidator{}

	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()

	err := dhtA.PutValue(ctxT, "/v/hello", []byte("valid"))
	if err != nil {
		t.Error(err)
	}

	ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
	defer cancel()
337
	valCh, err := dhtA.SearchValue(ctxT, "/v/hello", Quorum(-1))
338 339 340
	if err != nil {
		t.Fatal(err)
	}
Łukasz Magiera's avatar
Łukasz Magiera committed
341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365

	select {
	case v := <-valCh:
		if string(v) != "valid" {
			t.Errorf("expected 'valid', got '%s'", string(v))
		}
	case <-ctxT.Done():
		t.Fatal(ctxT.Err())
	}

	err = dhtB.PutValue(ctxT, "/v/hello", []byte("newer"))
	if err != nil {
		t.Error(err)
	}

	select {
	case v := <-valCh:
		if string(v) != "newer" {
			t.Errorf("expected 'newer', got '%s'", string(v))
		}
	case <-ctxT.Done():
		t.Fatal(ctxT.Err())
	}
}

366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403
func TestGetValues(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	dhtA := setupDHT(ctx, t, false)
	dhtB := setupDHT(ctx, t, false)

	defer dhtA.Close()
	defer dhtB.Close()
	defer dhtA.host.Close()
	defer dhtB.host.Close()

	connect(t, ctx, dhtA, dhtB)

	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()

	err := dhtB.PutValue(ctxT, "/v/hello", []byte("newer"))
	if err != nil {
		t.Error(err)
	}

	err = dhtA.PutValue(ctxT, "/v/hello", []byte("valid"))
	if err != nil {
		t.Error(err)
	}

	ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
	defer cancel()
	vals, err := dhtA.GetValues(ctxT, "/v/hello", 16)
	if err != nil {
		t.Fatal(err)
	}

	if len(vals) != 2 {
		t.Fatalf("expected to get 2 values, got %d", len(vals))
	}

404
	sort.Slice(vals, func(i, j int) bool { return string(vals[i].Val) < string(vals[j].Val) })
405 406 407 408 409 410 411 412 413

	if string(vals[0].Val) != "valid" {
		t.Errorf("unexpected vals[0]: %s", string(vals[0].Val))
	}
	if string(vals[1].Val) != "valid" {
		t.Errorf("unexpected vals[1]: %s", string(vals[1].Val))
	}
}

414 415 416 417 418 419 420 421 422 423 424 425 426
func TestValueGetInvalid(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	dhtA := setupDHT(ctx, t, false)
	dhtB := setupDHT(ctx, t, false)

	defer dhtA.Close()
	defer dhtB.Close()
	defer dhtA.host.Close()
	defer dhtB.host.Close()

	dhtA.Validator.(record.NamespacedValidator)["v"] = blankValidator{}
427
	dhtB.Validator.(record.NamespacedValidator)["v"] = testValidator{}
428 429 430 431

	connect(t, ctx, dhtA, dhtB)

	testSetGet := func(val string, exp string, experr error) {
432 433
		t.Helper()

434 435 436 437
		ctxT, cancel := context.WithTimeout(ctx, time.Second)
		defer cancel()
		err := dhtA.PutValue(ctxT, "/v/hello", []byte(val))
		if err != nil {
438
			t.Error(err)
439 440 441 442 443 444
		}

		ctxT, cancel = context.WithTimeout(ctx, time.Second*2)
		defer cancel()
		valb, err := dhtB.GetValue(ctxT, "/v/hello")
		if err != experr {
Łukasz Magiera's avatar
Łukasz Magiera committed
445
			t.Errorf("Set/Get %v: Expected '%v' error but got '%v'", val, experr, err)
446 447
		} else if err == nil && string(valb) != exp {
			t.Errorf("Expected '%v' got '%s'", exp, string(valb))
448 449 450 451 452 453 454 455 456 457 458 459 460
		}
	}

	// Expired records should not be returned
	testSetGet("expired", "", routing.ErrNotFound)
	// Valid record should be returned
	testSetGet("valid", "valid", nil)
	// Newer record should supersede previous record
	testSetGet("newer", "newer", nil)
	// Attempt to set older record again should be ignored
	testSetGet("valid", "newer", nil)
}

461
func TestInvalidMessageSenderTracking(t *testing.T) {
Steven Allen's avatar
Steven Allen committed
462 463 464
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

465
	dht := setupDHT(ctx, t, false)
Steven Allen's avatar
Steven Allen committed
466 467
	defer dht.Close()

468 469 470 471 472 473 474
	foo := peer.ID("asdasd")
	_, err := dht.messageSenderForPeer(foo)
	if err == nil {
		t.Fatal("that shouldnt have succeeded")
	}

	dht.smlk.Lock()
Steven Allen's avatar
Steven Allen committed
475 476 477 478
	mscnt := len(dht.strmap)
	dht.smlk.Unlock()

	if mscnt > 0 {
479 480 481 482
		t.Fatal("should have no message senders in map")
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
483 484
func TestProvides(t *testing.T) {
	// t.Skip("skipping test to debug another")
Steven Allen's avatar
Steven Allen committed
485 486
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
487

488
	dhts := setupDHTS(t, ctx, 4)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
489 490
	defer func() {
		for i := 0; i < 4; i++ {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
491
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
492
			defer dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
493 494 495
		}
	}()

496 497 498
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
499

500
	for _, k := range testCaseCids {
Matt Joiner's avatar
Matt Joiner committed
501
		logger.Debugf("announcing provider for %s", k)
Jeromy's avatar
Jeromy committed
502
		if err := dhts[3].Provide(ctx, k, true); err != nil {
503 504
			t.Fatal(err)
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
505 506
	}

507 508 509 510
	// what is this timeout for? was 60ms before.
	time.Sleep(time.Millisecond * 6)

	n := 0
511
	for _, c := range testCaseCids {
512 513
		n = (n + 1) % 3

Matt Joiner's avatar
Matt Joiner committed
514
		logger.Debugf("getting providers for %s from %d", c, n)
Jeromy's avatar
Jeromy committed
515 516
		ctxT, cancel := context.WithTimeout(ctx, time.Second)
		defer cancel()
517
		provchan := dhts[n].FindProvidersAsync(ctxT, c, 1)
518 519 520 521 522 523 524 525 526 527 528 529 530 531 532

		select {
		case prov := <-provchan:
			if prov.ID == "" {
				t.Fatal("Got back nil provider")
			}
			if prov.ID != dhts[3].self {
				t.Fatal("Got back wrong provider")
			}
		case <-ctxT.Done():
			t.Fatal("Did not get a provider back.")
		}
	}
}

Jeromy's avatar
Jeromy committed
533 534
func TestLocalProvides(t *testing.T) {
	// t.Skip("skipping test to debug another")
Steven Allen's avatar
Steven Allen committed
535 536
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Jeromy's avatar
Jeromy committed
537

538
	dhts := setupDHTS(t, ctx, 4)
Jeromy's avatar
Jeromy committed
539 540 541 542 543 544 545 546 547 548 549 550
	defer func() {
		for i := 0; i < 4; i++ {
			dhts[i].Close()
			defer dhts[i].host.Close()
		}
	}()

	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])

	for _, k := range testCaseCids {
Matt Joiner's avatar
Matt Joiner committed
551
		logger.Debugf("announcing provider for %s", k)
Jeromy's avatar
Jeromy committed
552 553 554 555 556 557 558 559 560 561 562 563 564 565 566 567 568
		if err := dhts[3].Provide(ctx, k, false); err != nil {
			t.Fatal(err)
		}
	}

	time.Sleep(time.Millisecond * 10)

	for _, c := range testCaseCids {
		for i := 0; i < 3; i++ {
			provs := dhts[i].providers.GetProviders(ctx, c)
			if len(provs) > 0 {
				t.Fatal("shouldnt know this")
			}
		}
	}
}

569 570 571 572 573 574 575 576 577 578
// if minPeers or avgPeers is 0, dont test for it.
func waitForWellFormedTables(t *testing.T, dhts []*IpfsDHT, minPeers, avgPeers int, timeout time.Duration) bool {
	// test "well-formed-ness" (>= minPeers peers in every routing table)

	checkTables := func() bool {
		totalPeers := 0
		for _, dht := range dhts {
			rtlen := dht.routingTable.Size()
			totalPeers += rtlen
			if minPeers > 0 && rtlen < minPeers {
579
				//t.Logf("routing table for %s only has %d peers (should have >%d)", dht.self, rtlen, minPeers)
580 581 582 583 584 585 586 587 588 589 590 591 592 593 594 595
				return false
			}
		}
		actualAvgPeers := totalPeers / len(dhts)
		t.Logf("avg rt size: %d", actualAvgPeers)
		if avgPeers > 0 && actualAvgPeers < avgPeers {
			t.Logf("avg rt size: %d < %d", actualAvgPeers, avgPeers)
			return false
		}
		return true
	}

	timeoutA := time.After(timeout)
	for {
		select {
		case <-timeoutA:
Matt Joiner's avatar
Matt Joiner committed
596
			logger.Debugf("did not reach well-formed routing tables by %s", timeout)
597 598 599 600 601 602 603 604 605 606 607
			return false // failed
		case <-time.After(5 * time.Millisecond):
			if checkTables() {
				return true // succeeded
			}
		}
	}
}

func printRoutingTables(dhts []*IpfsDHT) {
	// the routing tables should be full now. let's inspect them.
608
	fmt.Printf("checking routing table of %d\n", len(dhts))
609 610 611 612 613 614 615
	for _, dht := range dhts {
		fmt.Printf("checking routing table of %s\n", dht.self)
		dht.routingTable.Print()
		fmt.Println("")
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
616
func TestBootstrap(t *testing.T) {
617 618 619 620
	if testing.Short() {
		t.SkipNow()
	}

Steven Allen's avatar
Steven Allen committed
621 622
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
623

624
	nDHTs := 30
625
	dhts := setupDHTS(t, ctx, nDHTs)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
626 627 628
	defer func() {
		for i := 0; i < nDHTs; i++ {
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
629
			defer dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
630 631 632 633 634 635 636 637
		}
	}()

	t.Logf("connecting %d dhts in a ring", nDHTs)
	for i := 0; i < nDHTs; i++ {
		connect(t, ctx, dhts[i], dhts[(i+1)%len(dhts)])
	}

638
	<-time.After(100 * time.Millisecond)
639 640 641 642
	// bootstrap a few times until we get good tables.
	stop := make(chan struct{})
	go func() {
		for {
643
			t.Logf("bootstrapping them so they find each other %d", nDHTs)
Jeromy's avatar
Jeromy committed
644 645
			ctxT, cancel := context.WithTimeout(ctx, 5*time.Second)
			defer cancel()
646 647 648 649 650 651 652 653 654 655 656
			bootstrap(t, ctxT, dhts)

			select {
			case <-time.After(50 * time.Millisecond):
				continue // being explicit
			case <-stop:
				return
			}
		}
	}()

657
	waitForWellFormedTables(t, dhts, 7, 10, 20*time.Second)
658
	close(stop)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
659

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
660 661
	if u.Debug {
		// the routing tables should be full now. let's inspect them.
662 663 664 665 666
		printRoutingTables(dhts)
	}
}

func TestPeriodicBootstrap(t *testing.T) {
667 668 669
	if ci.IsRunning() {
		t.Skip("skipping on CI. highly timing dependent")
	}
670 671 672 673
	if testing.Short() {
		t.SkipNow()
	}

Steven Allen's avatar
Steven Allen committed
674 675
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
676 677

	nDHTs := 30
678
	dhts := setupDHTS(t, ctx, nDHTs)
679 680 681 682 683 684 685
	defer func() {
		for i := 0; i < nDHTs; i++ {
			dhts[i].Close()
			defer dhts[i].host.Close()
		}
	}()

686 687 688 689
	var cfg BootstrapConfig
	cfg = DefaultBootstrapConfig
	cfg.Queries = 5

690
	t.Logf("dhts are not connected. %d", nDHTs)
691 692 693 694 695 696 697 698 699 700 701
	for _, dht := range dhts {
		rtlen := dht.routingTable.Size()
		if rtlen > 0 {
			t.Errorf("routing table for %s should have 0 peers. has %d", dht.self, rtlen)
		}
	}

	for i := 0; i < nDHTs; i++ {
		connect(t, ctx, dhts[i], dhts[(i+1)%len(dhts)])
	}

702
	t.Logf("DHTs are now connected to 1-2 others. %d", nDHTs)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
703
	for _, dht := range dhts {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
704
		rtlen := dht.routingTable.Size()
705 706
		if rtlen > 2 {
			t.Errorf("routing table for %s should have at most 2 peers. has %d", dht.self, rtlen)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
707
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
708
	}
709

710 711 712 713
	if u.Debug {
		printRoutingTables(dhts)
	}

714
	t.Logf("bootstrapping them so they find each other. %d", nDHTs)
Matt Joiner's avatar
Matt Joiner committed
715 716
	for _, dht := range dhts {
		go dht.BootstrapOnce(ctx, cfg)
717
	}
718 719 720

	// this is async, and we dont know when it's finished with one cycle, so keep checking
	// until the routing tables look better, or some long timeout for the failure case.
721
	waitForWellFormedTables(t, dhts, 7, 10, 20*time.Second)
722 723 724

	if u.Debug {
		printRoutingTables(dhts)
725
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
726 727
}

728 729
func TestProvidesMany(t *testing.T) {
	t.Skip("this test doesn't work")
Steven Allen's avatar
Steven Allen committed
730 731
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
732 733

	nDHTs := 40
734
	dhts := setupDHTS(t, ctx, nDHTs)
735 736 737
	defer func() {
		for i := 0; i < nDHTs; i++ {
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
738
			defer dhts[i].host.Close()
739 740 741 742 743 744 745 746
		}
	}()

	t.Logf("connecting %d dhts in a ring", nDHTs)
	for i := 0; i < nDHTs; i++ {
		connect(t, ctx, dhts[i], dhts[(i+1)%len(dhts)])
	}

747
	<-time.After(100 * time.Millisecond)
748
	t.Logf("bootstrapping them so they find each other. %d", nDHTs)
Jeromy's avatar
Jeromy committed
749 750
	ctxT, cancel := context.WithTimeout(ctx, 20*time.Second)
	defer cancel()
751 752
	bootstrap(t, ctxT, dhts)

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
753 754 755 756 757 758 759 760
	if u.Debug {
		// the routing tables should be full now. let's inspect them.
		t.Logf("checking routing table of %d", nDHTs)
		for _, dht := range dhts {
			fmt.Printf("checking routing table of %s\n", dht.self)
			dht.routingTable.Print()
			fmt.Println("")
		}
761
	}
762

763
	providers := make(map[string]peer.ID)
764

765
	d := 0
766
	for _, c := range testCaseCids {
767 768
		d = (d + 1) % len(dhts)
		dht := dhts[d]
769
		providers[c.KeyString()] = dht.self
770

771
		t.Logf("announcing provider for %s", c)
Jeromy's avatar
Jeromy committed
772
		if err := dht.Provide(ctx, c, true); err != nil {
773 774
			t.Fatal(err)
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
775 776
	}

777 778
	// what is this timeout for? was 60ms before.
	time.Sleep(time.Millisecond * 6)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
779

780 781
	errchan := make(chan error)

Jeromy's avatar
Jeromy committed
782 783
	ctxT, cancel = context.WithTimeout(ctx, 5*time.Second)
	defer cancel()
784 785

	var wg sync.WaitGroup
786
	getProvider := func(dht *IpfsDHT, k cid.Cid) {
787
		defer wg.Done()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
788

789
		expected := providers[k.KeyString()]
790

791 792 793
		provchan := dht.FindProvidersAsync(ctxT, k, 1)
		select {
		case prov := <-provchan:
794 795
			actual := prov.ID
			if actual == "" {
796
				errchan <- fmt.Errorf("Got back nil provider (%s at %s)", k, dht.self)
797 798 799
			} else if actual != expected {
				errchan <- fmt.Errorf("Got back wrong provider (%s != %s) (%s at %s)",
					expected, actual, k, dht.self)
800 801 802
			}
		case <-ctxT.Done():
			errchan <- fmt.Errorf("Did not get a provider back (%s at %s)", k, dht.self)
Jeromy's avatar
Jeromy committed
803
		}
804 805
	}

806
	for _, c := range testCaseCids {
807 808
		// everyone should be able to find it...
		for _, dht := range dhts {
Matt Joiner's avatar
Matt Joiner committed
809
			logger.Debugf("getting providers for %s at %s", c, dht.self)
810
			wg.Add(1)
811
			go getProvider(dht, c)
812
		}
813 814 815 816 817 818 819 820 821 822
	}

	// we need this because of printing errors
	go func() {
		wg.Wait()
		close(errchan)
	}()

	for err := range errchan {
		t.Error(err)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
823 824 825
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
826
func TestProvidesAsync(t *testing.T) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
827
	// t.Skip("skipping test to debug another")
828 829 830
	if testing.Short() {
		t.SkipNow()
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
831

Steven Allen's avatar
Steven Allen committed
832 833
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
834

835
	dhts := setupDHTS(t, ctx, 4)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
836 837
	defer func() {
		for i := 0; i < 4; i++ {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
838
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
839
			defer dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
840 841 842
		}
	}()

843 844 845
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
846

Jeromy's avatar
Jeromy committed
847
	err := dhts[3].Provide(ctx, testCaseCids[0], true)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
848 849 850 851 852 853
	if err != nil {
		t.Fatal(err)
	}

	time.Sleep(time.Millisecond * 60)

Jeromy's avatar
Jeromy committed
854 855
	ctxT, cancel := context.WithTimeout(ctx, time.Millisecond*300)
	defer cancel()
856
	provs := dhts[0].FindProvidersAsync(ctxT, testCaseCids[0], 5)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
857
	select {
Jeromy's avatar
Jeromy committed
858 859 860 861
	case p, ok := <-provs:
		if !ok {
			t.Fatal("Provider channel was closed...")
		}
862
		if p.ID == "" {
Jeromy's avatar
Jeromy committed
863 864
			t.Fatal("Got back nil provider!")
		}
865
		if p.ID != dhts[3].self {
866
			t.Fatalf("got a provider, but not the right one. %s", p)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
867
		}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
868
	case <-ctxT.Done():
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
869 870 871 872
		t.Fatal("Didnt get back providers")
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
873
func TestLayeredGet(t *testing.T) {
874 875
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
876

877
	dhts := setupDHTS(t, ctx, 4)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
878 879
	defer func() {
		for i := 0; i < 4; i++ {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
880
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
881
			defer dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
882 883 884
		}
	}()

885 886
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
887
	connect(t, ctx, dhts[2], dhts[3])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
888

889
	err := dhts[3].PutValue(ctx, "/v/hello", []byte("world"))
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
890 891 892 893
	if err != nil {
		t.Fatal(err)
	}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
894
	time.Sleep(time.Millisecond * 6)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
895

Jeromy's avatar
Jeromy committed
896 897
	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
898 899 900
	val, err := dhts[0].GetValue(ctxT, "/v/hello")
	if err != nil {
		t.Fatal(err)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
901
	}
902 903 904

	if string(val) != "world" {
		t.Error("got wrong value")
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
905 906 907
	}
}

908 909 910 911 912 913 914 915
func TestUnfindablePeer(t *testing.T) {
	if testing.Short() {
		t.SkipNow()
	}

	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

916
	dhts := setupDHTS(t, ctx, 4)
917 918 919
	defer func() {
		for i := 0; i < 4; i++ {
			dhts[i].Close()
920
			dhts[i].Host().Close()
921 922 923 924 925 926 927 928
		}
	}()

	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[2], dhts[3])

	// Give DHT 1 a bad addr for DHT 2.
929 930
	dhts[1].host.Peerstore().ClearAddrs(dhts[2].PeerID())
	dhts[1].host.Peerstore().AddAddr(dhts[2].PeerID(), dhts[0].Host().Addrs()[0], time.Minute)
931 932 933

	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
934
	_, err := dhts[0].FindPeer(ctxT, dhts[3].PeerID())
935 936 937 938 939 940 941 942
	if err == nil {
		t.Error("should have failed to find peer")
	}
	if ctxT.Err() != nil {
		t.Error("FindPeer should have failed before context expired")
	}
}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
943
func TestFindPeer(t *testing.T) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
944
	// t.Skip("skipping test to debug another")
945 946 947
	if testing.Short() {
		t.SkipNow()
	}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
948

Steven Allen's avatar
Steven Allen committed
949 950
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
951

952
	dhts := setupDHTS(t, ctx, 4)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
953 954
	defer func() {
		for i := 0; i < 4; i++ {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
955
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
956
			dhts[i].host.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
957 958 959
		}
	}()

960 961 962
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
963

Jeromy's avatar
Jeromy committed
964 965
	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
966
	p, err := dhts[0].FindPeer(ctxT, dhts[2].PeerID())
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
967 968 969 970
	if err != nil {
		t.Fatal(err)
	}

971
	if p.ID == "" {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
972 973 974
		t.Fatal("Failed to find peer.")
	}

975
	if p.ID != dhts[2].PeerID() {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
976 977 978
		t.Fatal("Didnt find expected peer.")
	}
}
979

980
func TestFindPeersConnectedToPeer(t *testing.T) {
981 982
	t.Skip("not quite correct (see note)")

983 984 985 986
	if testing.Short() {
		t.SkipNow()
	}

Steven Allen's avatar
Steven Allen committed
987 988
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
989

990
	dhts := setupDHTS(t, ctx, 4)
991 992 993
	defer func() {
		for i := 0; i < 4; i++ {
			dhts[i].Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
994
			dhts[i].host.Close()
995 996 997 998 999
		}
	}()

	// topology:
	// 0-1, 1-2, 1-3, 2-3
1000 1001 1002 1003
	connect(t, ctx, dhts[0], dhts[1])
	connect(t, ctx, dhts[1], dhts[2])
	connect(t, ctx, dhts[1], dhts[3])
	connect(t, ctx, dhts[2], dhts[3])
1004 1005 1006 1007 1008 1009

	// fmt.Println("0 is", peers[0])
	// fmt.Println("1 is", peers[1])
	// fmt.Println("2 is", peers[2])
	// fmt.Println("3 is", peers[3])

Jeromy's avatar
Jeromy committed
1010 1011
	ctxT, cancel := context.WithTimeout(ctx, time.Second)
	defer cancel()
1012
	pchan, err := dhts[0].FindPeersConnectedToPeer(ctxT, dhts[2].PeerID())
1013 1014 1015 1016
	if err != nil {
		t.Fatal(err)
	}

1017
	// shouldFind := []peer.ID{peers[1], peers[3]}
Jeromy's avatar
Jeromy committed
1018
	var found []*pstore.PeerInfo
1019 1020 1021 1022 1023 1024 1025 1026 1027 1028
	for nextp := range pchan {
		found = append(found, nextp)
	}

	// fmt.Printf("querying 0 (%s) FindPeersConnectedToPeer 2 (%s)\n", peers[0], peers[2])
	// fmt.Println("should find 1, 3", shouldFind)
	// fmt.Println("found", found)

	// testPeerListsMatch(t, shouldFind, found)

Matt Joiner's avatar
Matt Joiner committed
1029
	logger.Warning("TestFindPeersConnectedToPeer is not quite correct")
1030 1031 1032 1033 1034
	if len(found) == 0 {
		t.Fatal("didn't find any peers.")
	}
}

1035
func testPeerListsMatch(t *testing.T, p1, p2 []peer.ID) {
1036 1037 1038 1039 1040 1041 1042 1043 1044

	if len(p1) != len(p2) {
		t.Fatal("did not find as many peers as should have", p1, p2)
	}

	ids1 := make([]string, len(p1))
	ids2 := make([]string, len(p2))

	for i, p := range p1 {
1045
		ids1[i] = string(p)
1046 1047 1048
	}

	for i, p := range p2 {
1049
		ids2[i] = string(p)
1050 1051 1052 1053 1054 1055 1056 1057 1058 1059 1060 1061
	}

	sort.Sort(sort.StringSlice(ids1))
	sort.Sort(sort.StringSlice(ids2))

	for i := range ids1 {
		if ids1[i] != ids2[i] {
			t.Fatal("Didnt find expected peer", ids1[i], ids2)
		}
	}
}

1062
func TestConnectCollision(t *testing.T) {
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1063
	// t.Skip("skipping test to debug another")
1064 1065 1066
	if testing.Short() {
		t.SkipNow()
	}
1067 1068 1069
	if travisci.IsRunning() {
		t.Skip("Skipping on Travis-CI.")
	}
1070

1071
	runTimes := 10
1072

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1073
	for rtime := 0; rtime < runTimes; rtime++ {
Matt Joiner's avatar
Matt Joiner committed
1074
		logger.Info("Running Time: ", rtime)
1075

Steven Allen's avatar
Steven Allen committed
1076
		ctx, cancel := context.WithCancel(context.Background())
1077

1078 1079
		dhtA := setupDHT(ctx, t, false)
		dhtB := setupDHT(ctx, t, false)
1080

1081 1082
		addrA := dhtA.peerstore.Addrs(dhtA.self)[0]
		addrB := dhtB.peerstore.Addrs(dhtB.self)[0]
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1083

1084 1085
		peerA := dhtA.self
		peerB := dhtB.self
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1086

1087
		errs := make(chan error)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1088
		go func() {
Jeromy's avatar
Jeromy committed
1089 1090
			dhtA.peerstore.AddAddr(peerB, addrB, pstore.TempAddrTTL)
			pi := pstore.PeerInfo{ID: peerB}
Jeromy's avatar
Jeromy committed
1091
			err := dhtA.host.Connect(ctx, pi)
1092
			errs <- err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1093 1094
		}()
		go func() {
Jeromy's avatar
Jeromy committed
1095 1096
			dhtB.peerstore.AddAddr(peerA, addrA, pstore.TempAddrTTL)
			pi := pstore.PeerInfo{ID: peerA}
Jeromy's avatar
Jeromy committed
1097
			err := dhtB.host.Connect(ctx, pi)
1098
			errs <- err
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1099 1100
		}()

1101
		timeout := time.After(5 * time.Second)
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1102
		select {
1103 1104 1105 1106
		case e := <-errs:
			if e != nil {
				t.Fatal(e)
			}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1107 1108 1109 1110
		case <-timeout:
			t.Fatal("Timeout received!")
		}
		select {
1111 1112 1113 1114
		case e := <-errs:
			if e != nil {
				t.Fatal(e)
			}
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1115 1116 1117 1118
		case <-timeout:
			t.Fatal("Timeout received!")
		}

Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1119 1120
		dhtA.Close()
		dhtB.Close()
Juan Batiz-Benet's avatar
Juan Batiz-Benet committed
1121 1122
		dhtA.host.Close()
		dhtB.host.Close()
Steven Allen's avatar
Steven Allen committed
1123
		cancel()
Jeromy's avatar
Jeromy committed
1124
	}
1125
}
1126 1127 1128 1129 1130

func TestBadProtoMessages(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

1131
	d := setupDHT(ctx, t, false)
1132 1133 1134 1135 1136 1137

	nilrec := new(pb.Message)
	if _, err := d.handlePutValue(ctx, "testpeer", nilrec); err == nil {
		t.Fatal("should have errored on nil record")
	}
}
1138 1139 1140 1141 1142 1143 1144 1145 1146 1147

func TestClientModeConnect(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	a := setupDHT(ctx, t, false)
	b := setupDHT(ctx, t, true)

	connectNoSync(t, ctx, a, b)

1148
	c := testCaseCids[0]
1149
	p := peer.ID("TestPeer")
1150 1151
	a.providers.AddProvider(ctx, c, p)
	time.Sleep(time.Millisecond * 5) // just in case...
1152

1153
	provs, err := b.FindProviders(ctx, c)
1154 1155 1156 1157 1158 1159 1160 1161 1162 1163 1164
	if err != nil {
		t.Fatal(err)
	}

	if len(provs) == 0 {
		t.Fatal("Expected to get a provider back")
	}

	if provs[0].ID != p {
		t.Fatal("expected it to be our test peer")
	}
Steven Allen's avatar
Steven Allen committed
1165 1166 1167 1168 1169 1170 1171 1172 1173
	if a.routingTable.Find(b.self) != "" {
		t.Fatal("DHT clients should not be added to routing tables")
	}
	if b.routingTable.Find(a.self) == "" {
		t.Fatal("DHT server should have been added to the dht client's routing table")
	}
}

func TestClientModeFindPeer(t *testing.T) {
1174
	ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
Steven Allen's avatar
Steven Allen committed
1175 1176 1177 1178 1179 1180
	defer cancel()

	a := setupDHT(ctx, t, false)
	b := setupDHT(ctx, t, true)
	c := setupDHT(ctx, t, true)

1181 1182
	connectNoSync(t, ctx, b, a)
	connectNoSync(t, ctx, c, a)
Steven Allen's avatar
Steven Allen committed
1183 1184

	// Can't use `connect` because b and c are only clients.
1185 1186
	wait(t, ctx, b, a)
	wait(t, ctx, c, a)
Steven Allen's avatar
Steven Allen committed
1187 1188 1189 1190 1191 1192 1193 1194 1195 1196 1197 1198 1199

	pi, err := c.FindPeer(ctx, b.self)
	if err != nil {
		t.Fatal(err)
	}
	if len(pi.Addrs) == 0 {
		t.Fatal("should have found addresses for node b")
	}

	err = c.host.Connect(ctx, pi)
	if err != nil {
		t.Fatal(err)
	}
1200
}
1201

Matt Joiner's avatar
Matt Joiner committed
1202 1203 1204 1205 1206 1207 1208 1209 1210 1211 1212 1213
func minInt(a, b int) int {
	if a < b {
		return a
	} else {
		return b
	}
}

func TestFindPeerQueryMinimal(t *testing.T) {
	testFindPeerQuery(t, 2, 22, 11)
}

1214
func TestFindPeerQuery(t *testing.T) {
Matt Joiner's avatar
Matt Joiner committed
1215 1216 1217 1218 1219 1220 1221 1222 1223 1224 1225 1226 1227 1228
	if testing.Short() {
		t.Skip("skipping test in short mode")
	}
	if curFileLimit() < 1024 {
		t.Skip("insufficient file descriptors available")
	}
	testFindPeerQuery(t, 20, 80, 16)
}

func testFindPeerQuery(t *testing.T,
	bootstrappers, // Number of nodes connected to the querying node
	leafs, // Number of nodes that might be connected to from the bootstrappers
	bootstrapperLeafConns int, // Number of connections each bootstrapper has to the leaf nodes
) {
1229 1230 1231
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

1232
	dhts := setupDHTS(t, ctx, 1+bootstrappers+leafs)
1233
	defer func() {
Matt Joiner's avatar
Matt Joiner committed
1234 1235 1236
		for _, d := range dhts {
			d.Close()
			d.host.Close()
1237 1238 1239
		}
	}()

Jeromy's avatar
Jeromy committed
1240
	mrand := rand.New(rand.NewSource(42))
1241 1242
	guy := dhts[0]
	others := dhts[1:]
Matt Joiner's avatar
Matt Joiner committed
1243 1244 1245 1246
	for i := 0; i < bootstrappers; i++ {
		for j := 0; j < bootstrapperLeafConns; j++ {
			v := mrand.Intn(leafs)
			connect(t, ctx, others[i], others[bootstrappers+v])
1247 1248 1249
		}
	}

Matt Joiner's avatar
Matt Joiner committed
1250
	for i := 0; i < bootstrappers; i++ {
1251 1252 1253
		connect(t, ctx, guy, others[i])
	}

Matt Joiner's avatar
Matt Joiner committed
1254 1255 1256 1257 1258
	var reachableIds []peer.ID
	for i, d := range dhts {
		lp := len(d.host.Network().Peers())
		//t.Log(i, lp)
		if i != 0 && lp > 0 {
1259
			reachableIds = append(reachableIds, d.PeerID())
Matt Joiner's avatar
Matt Joiner committed
1260 1261 1262 1263
		}
	}
	t.Logf("%d reachable ids", len(reachableIds))

1264 1265 1266
	val := "foobar"
	rtval := kb.ConvertKey(val)

Jeromy's avatar
Jeromy committed
1267
	rtablePeers := guy.routingTable.NearestPeers(rtval, AlphaValue)
Matt Joiner's avatar
Matt Joiner committed
1268
	assert.Len(t, rtablePeers, minInt(bootstrappers, AlphaValue))
1269

Matt Joiner's avatar
Matt Joiner committed
1270
	assert.Len(t, guy.host.Network().Peers(), bootstrappers)
1271 1272

	out, err := guy.GetClosestPeers(ctx, val)
Matt Joiner's avatar
Matt Joiner committed
1273
	require.NoError(t, err)
1274 1275 1276 1277 1278 1279

	var outpeers []peer.ID
	for p := range out {
		outpeers = append(outpeers, p)
	}

Jeromy's avatar
Jeromy committed
1280
	sort.Sort(peer.IDSlice(outpeers))
Steven Allen's avatar
Steven Allen committed
1281

Matt Joiner's avatar
Matt Joiner committed
1282 1283
	exp := kb.SortClosestPeers(reachableIds, rtval)[:minInt(KValue, len(reachableIds))]
	t.Logf("got %d peers", len(outpeers))
1284
	got := kb.SortClosestPeers(outpeers, rtval)
Jeromy's avatar
Jeromy committed
1285

Matt Joiner's avatar
Matt Joiner committed
1286
	assert.EqualValues(t, exp, got)
1287 1288
}

1289 1290 1291 1292 1293
func TestFindClosestPeers(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()

	nDHTs := 30
1294
	dhts := setupDHTS(t, ctx, nDHTs)
1295 1296 1297 1298 1299 1300 1301 1302 1303 1304 1305 1306 1307 1308 1309 1310 1311 1312 1313 1314 1315 1316 1317 1318 1319 1320
	defer func() {
		for i := 0; i < nDHTs; i++ {
			dhts[i].Close()
			defer dhts[i].host.Close()
		}
	}()

	t.Logf("connecting %d dhts in a ring", nDHTs)
	for i := 0; i < nDHTs; i++ {
		connect(t, ctx, dhts[i], dhts[(i+1)%len(dhts)])
	}

	peers, err := dhts[1].GetClosestPeers(ctx, "foo")
	if err != nil {
		t.Fatal(err)
	}

	var out []peer.ID
	for p := range peers {
		out = append(out, p)
	}

	if len(out) != KValue {
		t.Fatalf("got wrong number of peers (got %d, expected %d)", len(out), KValue)
	}
}
1321 1322

func TestGetSetPluggedProtocol(t *testing.T) {
1323 1324 1325
	t.Run("PutValue/GetValue - same protocol", func(t *testing.T) {
		ctx, cancel := context.WithCancel(context.Background())
		defer cancel()
1326

1327 1328 1329 1330 1331
		os := []opts.Option{
			opts.Protocols("/esh/dht"),
			opts.Client(false),
			opts.NamespacedValidator("v", blankValidator{}),
		}
1332

Steven Allen's avatar
Steven Allen committed
1333
		dhtA, err := New(ctx, bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)), os...)
1334 1335 1336
		if err != nil {
			t.Fatal(err)
		}
1337

Steven Allen's avatar
Steven Allen committed
1338
		dhtB, err := New(ctx, bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)), os...)
1339 1340 1341
		if err != nil {
			t.Fatal(err)
		}
1342

1343
		connect(t, ctx, dhtA, dhtB)
1344

1345
		ctxT, cancel := context.WithTimeout(ctx, time.Second)
1346
		defer cancel()
1347 1348 1349
		if err := dhtA.PutValue(ctxT, "/v/cat", []byte("meow")); err != nil {
			t.Fatal(err)
		}
1350

1351 1352 1353 1354
		value, err := dhtB.GetValue(ctxT, "/v/cat")
		if err != nil {
			t.Fatal(err)
		}
1355

1356 1357 1358 1359 1360
		if string(value) != "meow" {
			t.Fatalf("Expected 'meow' got '%s'", string(value))
		}
	})

1361 1362
	t.Run("DHT routing table for peer A won't contain B if A and B don't use same protocol", func(t *testing.T) {
		ctx, cancel := context.WithTimeout(context.Background(), 5*time.Second)
1363 1364
		defer cancel()

Steven Allen's avatar
Steven Allen committed
1365
		dhtA, err := New(ctx, bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)), []opts.Option{
1366 1367 1368
			opts.Protocols("/esh/dht"),
			opts.Client(false),
			opts.NamespacedValidator("v", blankValidator{}),
1369
		}...)
1370 1371 1372 1373
		if err != nil {
			t.Fatal(err)
		}

Steven Allen's avatar
Steven Allen committed
1374
		dhtB, err := New(ctx, bhost.New(swarmt.GenSwarm(t, ctx, swarmt.OptDisableReuseport)), []opts.Option{
1375 1376 1377
			opts.Protocols("/lsr/dht"),
			opts.Client(false),
			opts.NamespacedValidator("v", blankValidator{}),
1378
		}...)
1379 1380 1381 1382
		if err != nil {
			t.Fatal(err)
		}

1383
		connectNoSync(t, ctx, dhtA, dhtB)
1384

1385 1386 1387 1388 1389 1390 1391
		// We don't expect connection notifications for A to reach B (or vice-versa), given
		// that they've been configured with different protocols - but we'll give them a
		// chance, anyhow.
		time.Sleep(time.Second * 2)

		err = dhtA.PutValue(ctx, "/v/cat", []byte("meow"))
		if err == nil || !strings.Contains(err.Error(), "failed to find any peer in table") {
1392
			t.Fatalf("put should not have been able to find any peers in routing table, err:'%v'", err)
1393 1394
		}

1395 1396
		_, err = dhtB.GetValue(ctx, "/v/cat")
		if err == nil || !strings.Contains(err.Error(), "failed to find any peer in table") {
1397
			t.Fatalf("get should not have been able to find any peers in routing table, err:'%v'", err)
1398
		}
1399
	})
1400
}
1401 1402 1403 1404 1405 1406 1407 1408 1409 1410 1411 1412 1413 1414 1415 1416 1417 1418

func TestPing(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
	ds := setupDHTS(t, ctx, 2)
	ds[0].Host().Peerstore().AddAddrs(ds[1].PeerID(), ds[1].Host().Addrs(), pstore.AddressTTL)
	assert.NoError(t, ds[0].Ping(context.Background(), ds[1].PeerID()))
}

func TestClientModeAtInit(t *testing.T) {
	ctx, cancel := context.WithCancel(context.Background())
	defer cancel()
	pinger := setupDHT(ctx, t, false)
	client := setupDHT(ctx, t, true)
	pinger.Host().Peerstore().AddAddrs(client.PeerID(), client.Host().Addrs(), pstore.AddressTTL)
	err := pinger.Ping(context.Background(), client.PeerID())
	assert.True(t, xerrors.Is(err, multistream.ErrNotSupported))
}