GitLab

New Dialer

Fix simultaneous dials

they work with private data types, so there is no point in having them public

so that we exercise the dialWorker dial to self error path

we might get more connections because simultaneous dials can succeed
and we have both TCP and QUIC addrs by default

for consistency with the old dialer behaviour.

i want to use binary literals; technically only requires 1.13, but let's not be ancient

makes TestDialBackoff happy

fix: use 64bit stream/conn IDs

feat: close transports that implement io.Closer

Given 1k requests per second (assuming one stream per request), we can
easily loop around the stream ID after less than 2 months. 32bits is
plenty (usually) for connection-scoped stream IDs because individual
connections don't usually last that long, but isn't enough for a
_global_ stream ID.

Given that there's no reason for these to be 32bit IDs, let's just make
them 64bits.

This way, transports with shared resources (e.g., reused sockets) can clean them
up.

fixes https://github.com/libp2p/go-libp2p/issues/999

Otherwise, canceling one dial request will cancel all "joined" dial requests.

Given two relay connections, prefer the one that's non-transient.
Otherwise, a transient connection could prevent us from opening streams
even if we have a second non-transient connection through a better relay.